Bug#781248: RFS: golang-go-colorable/0.0~git20140924-1 [ITP#781244]
Alexandre Viau <alexandre@alexandreviau.net> writes:
> I'll be waiting for someone from pkg-go then :)
Hi Alexandre!
I am not with pkg-go -- sorry! But I do have a quick review for you
that contains some things which you can work on while you wait.
Because there are so many variants of the MIT license, the Debian
copyright-format policy wants the license specified as the more specific
version - Expat is usually compatible with "MIT", but it depends what
the upstream author wants.
The file _example/main.go doesn't comply with gofmt. A quick
run-through of gofmt and sending the patch upstream is an easy fix for
that.
Other than that, there's an extra newline in d/copyright.
The RFS bug for this package should /probably/ block on the RFS bug for
golang-go-isatty, since this package depends on that one. Not a big
deal, though.
Hope that helps, and thank you for your contributions to Debian!
--
Harlan Lieberman-Berg
~hlieberman
Reply to: