Hi Riley, On Wed, Mar 25, 2015 at 05:15:36PM +1100, Riley Baird wrote: > That's great! I'm not a DD, so I can't sponsor your package, but here > are my thoughts: Thanks for the review. > d/changelog: > -As this is a new package, priority should be "low". Added to my pre-upload checklist. I make pre-release uploads for testing to a private repository for my friends and upstream mailing lists. Looks like this got changed somewhere by dch. > d/copyright: > -Remove the copyright symbol. > -If you worked on the package this year, you should probably add 2015 > to the years. Similarly, upstream development has continued past 2013 > so you should probably give 2013-2015 as the years for the non-Debian > parts. Years have been updated. I've had the copyright symbol in my other packages, and this is part of the Debian Med package template created by tille. If the copyright symbol is against policy, I have a lot of things to fix as will others. Left it in for now. > d/docs: > -Include README.md as well. Good point. Done. > d/pyqso.1: > -You should try submitting this upstream. Already done. > General: > -I got the below error when building. Have you forgotten a > build-depends, or is this message to be expected? > > ERROR:root:Could not import a non-standard Python module > needed by the GreyLine class, or the version of the non-standard module > is too old. Check that all the PyQSO dependencies are satisfied. > ERROR:root:Could not import the Hamlib module! ERROR:root:Could not > import the Hamlib module! reading sources... Yep. The software includes the modules if they're available, and they are dependencies of the binary package, but not required during the build. Might ask upstream to change "ERROR" to "Warning" so it's a bit less scary. The new package has been uploaded to mentors.d.o. Thanks, Iain. -- e: irl@fsfe.org w: iain.learmonth.me x: irl@jabber.fsfe.org t: EPVPN 2105 c: 2M0STB g: IO87we p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49
Attachment:
pgpTuAoTJCQ9T.pgp
Description: PGP signature