Bug#780584: RFS: s3cmd/1.5.2-1 ITA

[Mikhail Gusarov <dottedmag@debian.org>]

Ack.

On Wed, 18 Mar 2015, at 11:29, Gianfranco Costamagna wrote:
> 
> 
> Hi Harlan!
> 
> (ccing Mikhail so he can ack/nack the GPL-2 to GPL-2+ change)
> 
> 
> 
> >The most concerning issue to me is the change in d/copyright from GPL-2
> >to GPL-2+ for the files under debian/.  Matching them to upstream is
> >best practice, to be sure, but to do so needs the permission of the
> >authors of all the files underneath there - especially, it looks like,
> >Mikhail Gusarov.  It's not clear to me whether Matt Domsch's permission
> >might also be needed; it certainly couldn't hurt, though.
> 
> 
> I didn't "hide" this from changelog, because I know this needs
> permission,
> and this is why I'm ccing him (sorry, I was sure I mentioned it in the
> ITA bug, bad me)
> 
> Having it as GPL-2 makes it hard to forward patches to upstream (of
> course I can
> release *my* patches under GPL-2+, but seems better to relicense the
> debian packaging in my
> opinion)
> 
> this is also why I didn't fix the nitpicks, as soon as I get confidence
> with the licensing I'll
> fix them directly upstream, they aren't on top of the issues in my
> opinion
> 
> >The man page has a couple of errors as well - groff is picking up some
> >text and trying to apply it as a macro.  There are also unescaped
> >"-"'s that need to be escaped so they are not mistaken as hyphens
> >instead of minuses.  There's also a spelling error in the man file.  All
> >of these are upstream problems - probably with the tool they are using
> >to create the manpage itself - but should be fixed if possible.
> 
> >Other than that, the remaining tweaks are minor.  You should install the
> >upstream changelog since it's provided.  Upstream does provide GPG
> >signatures of the downloads, so you should verify them if possible - the
> >uscan(1) manpage has details about how to do so.  That will require
> >changing the watch file from github to sourceforge.
> 
> 
> nope, the asc file is also there on github, but for some reasons uscan is
> picking
> it and failing for another reason.
> (it is my first time I add an upstream signing key, help is appreciated)
> 
> >Thanks again for your work on s3cmd, and on Debian!  If you have
> >questions, please reach out to me.
> 
> 
> thanks for the review
> 
> Gianfranco