Bug#780069: RFS: codespell/1.7-1 ITA
Hi Paul!
>Please use an X-Debbugs-CC pseudo-header in the mail body instead in >
>future:
I will.
> The debian/upstream/upstream file is incorrectly named.
Fixed.
> The patch isn't the right way to override the default prefix. Please
> replace it by changes to debian/rules (override_dh_auto_build) if
>debhelper isn't already passing the right prefix.
Solved:
override_dh_auto_install:
dh_auto_install -- prefix=/usr
> Did you review the changes to policy since 3.9.5? Were any changes
> needed? Please mention in debian/changelog if no changes were needed.
No changes needed. Updated the changelog.
> I would suggest wrapping the URL and regex on different lines in
> debian/watch, you can use the line continuation character (backslash)
> to do that.
Done.
> The file debian/codespell.1 is an automatically generated file, all
> automatically generated files should be created at build time and not
> be present in version control systems or upstream tarballs, otherwise
> they will get out of date. Please add a command to debian/rules to
> generate it after dh_auto_build.
> The file debian/codespell.1 contains an incorrect path to the
> dictionary as it seems you created it using codespell.py instead of
> codespell, which has the right path after it is generated from the
> codespell.py script.
Solved: override_dh_installman:
> Are you really working on code in /tmp? I'd strongly suggest working
> in /home instead since /tmp is world-writable.
No, I used /tmp to clone the upstream repo and generated the manpage
from there. I fixed that.
> Upstream has added a check target in the Makefile so the
> override_dh_auto_test target can be removed from debian/rules.
Yes, but the make check is incorrect. Already fixed upstream, and added
a patch for it.(https://github.com/lucasdemarchi/codespell/issues/26)
> You appear to have forgotten to close #779900 in debian/changelog.
Fixed.
> #763266 is marked as fixed-upstream, did 1.7 fix it? If so you will
> want a debian/changelog entry like this:
It is not contained in the 1.7 release. I added a patch.
> Please run tagpending (from devscripts) when uploading to mentors.
Done and will do in the future.
> Automatic checks:
> $ cme check dpkg
> ...
> Warning in 'patches:"0001-fix-install-prefix.patch" Synopsis' value
> <undef>: Empty synopsis (code is: 'defined $_ && /\w/ ? 1 : 0 ;')
What tool is that?
> $ find -type f -iname '*.asc' -exec cat {} + | hot dearmor | hokey >lint
> ...
> Self-sig hash algorithms: [SHA1]
>
https://help.riseup.net/en/security/message-security/openpgp/best->practices#self-signatures-should-not-use-sha1
I will try to convince upstream to change that.
> $ pep8 --ignore W191 .
> <lots of messages>
Contacted upstream. I will provide a pull-request on github:
https://github.com/lucasdemarchi/codespell/issues/27#issuecomment-78270203
Thank you very much for your extensive review.
I uploaded a new version to mentors:
http://mentors.debian.net/package/codespell
Greetings
Peter
Reply to: