On Thu, Feb 19, 2015 at 10:04:28AM (+0100), Tobias Frost wrote:
Hi Sebastien, Thanks for adopting the package. I will sponsor your upload. (However, I cannot do it now, but I will do a througouh review tonight or tomorrow)
Hi Tobias, Sorry for the delay, and many thanks for the review and valuable comments!
Some first remarks: -> I recommend to avoid uploading a new upstream version to sid during the freeze. Use experimental.
You are right, I've just fixed that.
-> please integrate get-orig-source.sh into d/rules if it is still required (is the new source now DFSG compliant? If so, document that in the changelog!)
The upstream tgz is still not DFSG compliant, we still remove pdf doc files (#737478).
-> please update d/rules to short debhelper format
It's more cleaner now \o/ I think it's ok now.
-> please upgrade to debhelper compat level 9 -> please cleanup d/patches for patches applied upstream and check if not-forwarded patches should be forwarded
Fixed, also suffixed by .patch extension and prefixed by a number id.
-> you can drop the B-D version constraint on dpkg-dev -- even oldstable fulfilles it
A relic of the past :-)
-> can you please check if the override for conflicts-with-version is valid? (I did not check the details, so this could be wrong; it just smells like you want to have Replaces: and Breaks: here, see Policy 7.6.1) If you do a change here, be sure to properly test this.
Just checked, and according Policy §7.6.1 I've replaced Conflicts by Breaks, It seems working. Thanks again for the help! Seb -- Sebastien Badia
Attachment:
signature.asc
Description: Digital signature