[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779377: RFS: classified-ads/0.03-1 / ITP



>   I am looking for a sponsor for my package "classified-ads"

That's great! I'm not a DD, so I can't sponsor your package, but I've had a look at it, and here are some things that I've noticed:

d/changelog:
-This file should only contain Debian-related changes. Upstream changes 
-You won't be able to upload to unstable at the moment, since it's frozen for jessie. You should change this to "experimental".

d/compat:
-Debhelper 7 is old. You should switch to 9.

d/classified-ads.1:
-You should include this with the software, not just in Debian.
-You should get rid of the comments explaining what nroff is.
-You note that "Upon uninstall of the program, the datafile is left lingering around". You might want to ask someone else, but this seems like bad practice.

d/control:
-Priority should be "optional", not "extra".
-Either fill in the Vcs-* fields, or get rid of them.
-You've listed some dependencies twice: once in d/classified-ads.substvars, and once in d/control.
-The long description of your package has some spelling/grammatical errors and is a bit short. Perhaps you could take some of the information off your homepage and put it there?

d/copyright:
-You should use DEP-5 copyright

d/docs:
-If you don't have any docs, get rid of this file. Otherwise, put them in there.

d/README.source:
*Delete this file if there is no reason to keep it.

d/rules:
-You'll need to update this to dh9 syntax. See here for a guide: https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#rules

General:
-It's a good idea to keep Debian development and upstream development separate. Don't include the debian/ directory with your upstream tarballs.
-I don't think that Debian can legally distribute classified-ads, since Nokia has not made the OpenSSL exception. On the other hand, I'm not sure if the LGPL cancels this out. I'm going to ask debian-legal.

Good luck getting your package into Debian,

Riley Baird

Attachment: pgpOMWeVAVDE2.pgp
Description: PGP signature


Reply to: