Bug#778546: RFS: miceamaze/4.2-1 -- video game with mice in a maze
Control: tags -1 + moreinfo
On Mon, Feb 16, 2015 at 10:38 PM, Raphaël Champeimont wrote:
> miceamaze - video game with mice in a maze
There is one issue that need to be fixed before I will upload the package:
The debian/copyright file needs to be updated for the new copyright
year. It also needs updating for the new files that are under
different licenses or have different copyright holders (data/music/
and data/mazes/maze13.txt). Please note that a full copy of the CC-BY
3.0 license needs to be added to debian/copyright, so offline users
can read the license.
Other thoughts:
On a system with two screens (laptop + external screen), full-screen
mode crosses the two screens which makes the menu hard to read and
cuts part of it off.
In chromium-bsu I was able to get nice anti-aliased text by passing
GLC_TEXTURE to glcRenderStyle, but for some reason that only produces
white squares in miceamaze.
You might want to mention the Standards-Version in debian/changelog.
If you have gone through the upgrading checklist and there aren't any
changes that apply to miceamaze, you can say just "Bump
Standards-Version, no changes needed".
http://www.debian.org/doc/debian-policy/upgrading-checklist
You might want to mention the reason for the Priority change in
debian/changelog.
I would have indented the second debian/changelog item like this:
* New upstram release 4.2 (Closes: #766820)
- Removed creation timestamp in PNG generation (Closes: #778491)
ttf-dejavu-core is a transitional dummy package, you could depend on
fonts-dejavu-core | ttf-dejavu-core instead.
You may want to work on porting the code to SDL2. chromium-bsu is an
example of a game that supports SDL and SDL2 (in upstream git only).
The debian/patches directory is empty and could be removed.
There are two spelling errors:
$ codespell --quiet-level=3
./src/Functions.h:149: occured ==> occurred
./src/AIVertex.h:33: colum ==> column
The include-what-you-use tool (from the iwyu Debian package) suggests
a lot of files that are missing headers for the variables and
functions that they use. I ran this command:
$ find -type f \( -iname '*.c' -o -iname '*.cc' -o -iname '*.cxx' -o
-iname '*.cpp' -o -iname '*.h' -o -iname '*.hh' -o -iname '*.hxx' -o
-iname '*.hpp' \) -exec include-what-you-use {} \;
I would suggest renaming the upstream README.txt file to INSTALL.txt.
The upstream LICENSE.txt still contains details about the
Bitstream/DejaVu license even though that was removed from the source
tarball.
The upstream LICENSE.txt is missing copyright/license info for
maze13.txt, which appears to have been contributed by someone else?
This is a better URL for the Ogg file from ccmixter, I found it in the
metadata of the Ogg file:
http://ccmixter.org/files/George_Ellinas/14073-
The upstream ChangeLog.txt is missing information about versions from
2.1 to 4.2.
You've changed the mouse image and introduced 2 modified copies of it.
This could be problematic if you want to tweak the mouse image or use
different modifications in the future. Personally I would have done it
like this: mouse.png containing the normal mouse image, helmet.png
containing the mouse helmet and sickness.png containing the sickness
pattern. Then at build time you would use imagemagick to overlay the
helmet on the mouse image to create drill_mouse.png and similarly to
create sick_mouse.png. Using SVG for the mouse image would give you
more options for modifying the mouse too.
The Ogg files aren't very modifiable, for example you could not easily
change the drums to different drum or to a sample of someone hitting
two rocks together.
lintian complaints:
P: miceamaze source: debian-watch-may-check-gpg-signature
I: miceamaze: arch-dep-package-has-big-usr-share 12285kB 98%
For the first one, refer to these URLs:
https://lintian.debian.org/tags/debian-watch-may-check-gpg-signature.html
https://wiki.debian.org/debian/watch#Cryptographic_signature_verification
https://help.riseup.net/security/message-security/openpgp/best-practices
For the second one, refer to these URLs:
https://lintian.debian.org/tags/arch-dep-package-has-big-usr-share.html
As you are upstream for a game, you may want to look at these:
https://wiki.debian.org/UpstreamGuide
http://www.freedesktop.org/wiki/Games/Upstream/
--
bye,
pabs
https://wiki.debian.org/PaulWise
Reply to: