[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#777347: RFS: pidgin-gnome-keyring/2.0-1 [ITP] [RFP #714018] -- integrates pidgin (and libpurple) with the system keyring



Hi Luca,

On 2015-02-07 16:45, luca.boccassi@gmail.com wrote:
> I am looking for a sponsor for my package "pidgin-gnome-keyring"

I'm not a DD yet, so I can't sponsor your package, but I did a review on
what to improve to attract more potential sponsors:

* Create a debian/watch file for use with `uscan` so automatic checks
for newer upstream releases are possible.

* The Vcs-* fields do not point to a repository that contains the
packaging. Furthermore, the use of services like github is disputed for
packaging in Debian. Maybe collab-maint on Alioth is a better place to
keep your VCS, but that's up to you and your sponsor.

* You do not have to use overrides for dh_auto_install and
dh_installdocs in debian/rules. Youc can use debian/<package>.install
and debian/<package>.docs for a source package with multiple binary
packages.

* The PHONY target declaration is not really necessary.

* Is the packaging (debian/*) really from Ali Ebrahim as described in
debian/copyright or was it your work?

Cheers,
-- 
Michael Fladischer
Fladi.at

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: