[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#775194: RFS: mininet/2.2.0 ITP - process-based network emulator



 ❦ 12 janvier 2015 14:30 +0100, Tomasz Buchert <tomasz.buchert@inria.fr> :

>   It builds those binary packages:
>
>     mininet - process-based network emulator
>
>   To access further information about this package, please visit the following URL:
>
>   http://mentors.debian.net/package/mininet
>
>   Alternatively, one can download the package with dget using this command:
>
>   dget -x http://mentors.debian.net/debian/pool/main/m/mininet/mininet_2.2.0-1.dsc
>
>   More information about hello can be obtained from
>   http://www.mininet.org.

In Ubuntu, the package is maintained by James Page. I pinged him a week
ago about packaging it in Debian but got no answer. Your package seems
an original work. Did you try to reach James about that? Did you look at
how the problems you got have been solved in this version?

About the package:

 - in d/control, you recommend openvswitch-controller but no such
   package exists in Debian.
 - in d/copyright, you license debian/* under GPL-2+ but since the
   original software is licensed as MIT, it would be "better"
   to use the same license. This allows upstream to integrate your
   changes more easily.
 - in d/copyright, the license is MIT with a preface, just use MIT as
   the keyword (but keep the whole license).
 - in d/repack, why is this script here if not used?
 - in d/rules, you use python_distutils as a build system, this will
   call "python setup.py clean" in dh_auto_clean, not "make clean". This
   explains why you have to use "make clean". As for CPPFLAGS, this is
   because the Makefile don't include it. I think both of your fixes are
   fine.
 - d/TODO should be removed if those problems are solved.

I have not tested the result, but the package looks good otherwise.
-- 
Debian package sponsoring guidelines:
 http://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: