[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#774348: RFS: hebrew-cal/1.0 [ ITP]



I have fixed all of those. i will be happy to get sponsor for this.

2015-01-01 22:45 GMT+02:00 Riley Baird wrote:
Hi, I'm not a DD, so I can't sponsor your package, but I've had a look
and here are some things I've noticed:

* Your package should be a non-native package, because it isn't
exclusive to Debian.

fix.
 
* You need to update the standards version in d/control to 3.9.6

fix. 
* You say that hebrew-cal is based on libhdate and zmanim-java-API.
Debian policy forbids convenience copies, so would it be possible to
simply depend on the libhdate packages? You might also have to package
kosherjava to meet this policy, but maybe someone else on the list can
confirm this.

i changed this, and it is now depend on libhdate. 
about  zmanim-java-API: I took from him a very small piece of code, I fork it, and if it will be a problem, I will cut it...
 
* You need to make a manpage for hebrew-cal.

fix 
* You should have a watch file.

fix 
* In data/hebrew-cal.desktop, you do not need to specify the encoding.

fix. 
* In data/hebrew-cal.desktop, add a "Keywords" field. See
https://lintian.debian.org/tags/desktop-entry-lacks-keywords-entry.html
for more information.

fix. 
* Your short description would ideally give more information than
"Hebrew Calendar". How about "a beautiful, Qt-based Hebrew calendar"

* Your long description doesn't sound natural. How about:
 hebrew-cal is a beautifully designed Hebrew calendar
 which is very easy to use and customize.
 The calendar includes Hebrew dates, holidays,
 times, Parshiot Hashavua, Daf Yomi, and more.
 .
 The appearance can be changed, the colors are editable
 and calendars can be printed.
 .
 It is written in C++ using the Qt libraries, and is
 based on the libhdate code and zmanim-java-API.

fix. 
Good luck getting your package into Debian!

Riley Baird

here is my changlog:
hebrew-cal (1.1-1) unstable; urgency=low
 * update control file
 * add man file
 * add watch file
 * depend on hdate
 * change to quilt
-- Avi Software <avisoftware123@gmail.com> Wed, 07 Jan 2015 12:55:27 +0200

thank you everybody. 
Avi Software.


Reply to: