Bug#773611: RFS: histring/1.1.1-1 [ITP] - general purpose highlighting tool
I don't intend to sponsor this package, but here's my review:
* Tong Sun <suntong001@users.sourceforge.net>, 2015-01-02, 15:38:
http://mentors.debian.net/debian/pool/main/h/histring/histring_1.1.1-1.dsc
Typos:
warrented -> warranted
neccessary -> necessary
hilighting -> highlighting
bolded -> emboldened [I'm not sure about this one]
expresstions -> expressions
markerns -> markers
compilied -> compiled
Copyright information for at least getopt* is missing from d/copyright.
You build-depend on autotools-dev, but don't actually use it any way
(AFAICS).
Please rebuild the configure script from source. You might want to use
dh-autoreconf for this purpose.
How was your .orig.tar generated? It is different than the one uscan
downloads.
I am allergic to the "debianize" verb, and also wonder why two items are
needed in the changelog... So I'd like to propose to replace them both
with this one:
* Initial release (closes: #759166).
What is the purpose of your debian/source/options? It doesn't seem
necessary to me.
The explicit clean target in debian/rules doesn't look very useful to me
either.
--
Jakub Wilk
Reply to: