[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768878: RFS: sfarklib/0.20131219gitee08d0c-1 [ITP]



Hi,

Then I've added d/gbp.conf and watch files to both packages. You may
have a new look now.

Thanks for telling about the problems.


Ruben

2014-11-16 20:33 GMT+01:00 Ruben Undheim <ruben.undheim@gmail.com>:
> Hi Ross,
>
>> This looks like a good little package (and its partner), and I would be
>> happy to be a co-uploader within the Debian Multimedia Team. I am nearly
>> a DM, but I cannot sponsor the package.
>
> Great! I will add you to the uploaders field.
>
>> Unfortunately I fell at the first hurdle when taking a look at it. It
>> seems you have made the package directly from the upstream git
>> repository. This is okay, but I was not able to easily test build the
>> package without an original tarball.
>
> So the reason for this is that the day before yesterday I changed the
> version names from
>    0.20131219gitee08d0c-1 to  2.23+20131219gitee08d0c-1 for sfarklib
>    0.20130812git80b1da3-1  to 0~20130812git80b1da3-1 for sfarkxtc
>
> I did it in a hurry and completely forgot to retag and rerun
> "pristine-tar commit"... Since then I've been without Internet
> connection. Now it should work again though. Sorry about this.
>
>> Maybe it would be a good idea to build and upload to debian.mentors even
>> if the eventual sponsor comes form within the debian-multimedia team?
>> That makes it easy to to check for lintian errors without the reviewer
>> having to build it themselves. It also means there is an *orig.tar for
>> the reviewer :-) without having to create one.
>
> Yes, it is a good idea. My previous experience has been that I ended
> up changing small details so many times and reuploading to mentors so
> many times that this time I wanted to wait until it becomes a bit more
> stable.
>
>> Even though the package is from a git snapshot, you should still provide
>> a d/watch file, so that all the automated tools can compare the current
>> version with upstream releases (they have made some).
>
> I can add a watch file. Upstream has created some tags for sfarklib,
> but not for sfarkxtc. I've also been in contact with upstream asking
> if he wanted to create new real version numbers, but he is of the
> opinion that it's not necessary because the package is so small.
>
>> When I tried to build with gbp and the --pristine-tar option, the build
>> failed because the upstream tag is different to the entry in d/changelog.
>
> It should work now because of the reason explained above. Sorry
>
>> It is a good idea to provide a gbp.conf file. The Debian Multimedia
>> packaging wiki
>> (https://wiki.debian.org/DebianMultimedia/DevelopPackaging) recommends
>> at least the default option of pristine-tar being True.
>
> I use pristine-tar = True in my gbp.conf on my computer. I see now
> that it is possible to put a file in debian/ also. I didn't know about
> that option - only the  .git/gbp.conf option and the ~/.gbp.conf.
> Thanks. Will fix.
>
> Best regards,
> Ruben


Reply to: