Bug#766833: RFS: fuzzylite/5.0+dfsg-1 [ITP]

[Johannes Schauer <j.schauer@email.de>]

Hi Stephen,

Quoting Stephen Kitt (2014-11-04 00:41:57)
> I've taken a look at the package and it seems fine, apart from the two points
> remaining from your exchanges with Jakub:
> 
> * the hard-coded paths in src/Console.cpp
> * the spelling/grammar errors
> 
> Regarding the latter, I prefer "... method `static bar` was made `virtual
> foo::bar`, which allows it to be overridden".

Oh sorry, I already submitted a patch to upstream which says:

    Its method `static tsukamoto()` was moved to `virtual WeightedDefuzzifier::tsukamoto()`, which allows overriding it

And upstream already applied it. https://github.com/fuzzylite/fuzzylite/pull/11

Is the grammar still wrong and should I prepare another pull request?

(plus, of course fix this in the packaging until the next upstream release)

> Do you have any idea what should be done about the former?

The result of the former is, that two possible but undocumented commandline
arguments of the fuzzylite binary do not work and instead produce an error that
they cannot find some files.

Upstream's opinion is, that this functionality is not something that is
intended to be used by anybody but them:

https://github.com/fuzzylite/fuzzylite/issues/10

I see two ways to go forward:

 1) We accept that the two commandline arguments that are not working are
    neither found in the --help output of the binary nor in the man page I
    wrote, so it's unlikely the user will ever run them except if they read the
    source code. The solution would thus be ignoring the issue.

 2) Make a quick patch which removes those two option from the commandline
    interface

I'm inclined to do the former, because I see little difference between the
program failing because "there is no such commandline argument" and the program
failing because "you are not upstream" because the chances that the user will
ever have this problem go towards zero as neither of those two non-working
options are documented anywhere but the source code itself.

What do you think?

Thanks!

cheers, josch