Control: tags -1 + moreinfo [I don't intend to sponsor this package. Sorry!] * Gabriel Pérez-Cerezo <gabriel@gpcf.eu>, 2014-11-01, 11:32:
http://mentors.debian.net/debian/pool/main/2/2048/2048_1.0-3.dsc
Fun fact: we've had only one source package with a digit-only name so far: https://packages.qa.debian.org/3/3270.html
The copyright file doesn't say where the source was downloaded from. This is serious violation of Policy §12.5. [The package should not be uploaded until this bug is fixed, so I'm tagging the bug +moreinfo.]
Speaking of source, how was the .orig.tar generated? I don't see any tarballs on the upstream homepage.
The License field in machine-readable copyright files use the same rules as the long description in a package's Description field in control files (see Policy §5.6.13). So the License texts should be indented by a single space, not two.
The short licence name should be Expat, not MIT.The order of Files paragraphs in debian/copyright matters, and it's wrong in your file. More general paragraphs should be given first, followed by more specific overrides.
It's better to put the license text into a stand-alone license paragraph than to include it twice.
The extended package description is probably too short. if this is the initial release, why is the package revision 3?"sid" as distribution name in the changelog is fine, although it's customary to use "unstable" instead.
blhc(1) says: CFLAGS missing (-g -O2 -fstack-protector-strong -Wformat -Werror=format-security): gcc 2048.c -o 2048 CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc 2048.c -o 2048 LDFLAGS missing (-Wl,-z,relro): gcc 2048.c -o 2048 CFLAGS missing (-g -O2 -fstack-protector-strong -Wformat -Werror=format-security): gcc 2048.c -o 2048 CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc 2048.c -o 2048 LDFLAGS missing (-Wl,-z,relro): gcc 2048.c -o 2048 I'm not sure how is this supposed to work: snprintf(color,length,"\033[38;5;%d;48;5;%dm",*foreground,*background);console_codes(4) says that 38 is "set underscore on, set default foreground color", 5 is "set blink", and 48 is not documented. In any case, the result it quite horrible here (wheezy kernel, fbcon, 512 character font; see the attachment).
There's a buffer overflow for very long HOME: $ HOME=/$(perl -E'say "x"x4242') 2048 Segmentation fault NB, some of the problems above are detected by Lintian: I: 2048 source: unused-file-paragraph-in-dep5-copyright paragraph at line 4 W: 2048: hardening-no-relro usr/games/2048 I: 2048: hardening-no-fortify-functions usr/games/2048 I: 2048: extended-description-is-probably-too-short -- Jakub Wilk
Attachment:
2048-fbcon.png
Description: PNG image
