[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#763540: Review of psocksxx/0.0.5-1



On Fri, 2014-10-03 at 13:36 +0200, Jörg Frings-Fürst wrote:

> New package is uploaded to mentors[1].

The package looks good to me. I don't have time for sponsorship but I
would encourage the regular sponsors on debian-mentors to upload this.

> The reason is that I want use GPL-3+ for my work. But for your intention
> I set the patch to the license of the source file(s). I thinks that's a
> good way, especially by sources with more then one licenses.

Fair enough.

> I have move the build part to override_dh_auto_build.
> I want to copy the doxygen generated docu in a subdir (docs). With
> d/*.docs are all files in doc directory. A second parameter link in
> d/*.install are not supported.

I see.

> Is a override necessary? Until now I only know the only errors and
> warnings are to be overwritten.

lintian overrides are only for scenarios where lintian is incorrect, not
for actual issues that you don't intend to fix. They are also not for
experimental, pedantic or info level issues. So all of these issues
should either be ignored or fixed but not overridden.

> This duplicate files comes from doxygen. 

If you would like to fix this, please checkout this tip:

https://wiki.debian.org/dedup.debian.net#Tips_for_reducing_duplication_in_packages

For debian-watch-may-check-gpg-signature there isn't much you can do
because upstream isn't releasing tarballs and Debian's infrastructure
for dealing with such upstreams isn't up to scratch yet (help welcome).
However you could ask upstream to OpenPGP-sign their git tags and
commits. Please point them at the following links too.

http://mikegerwitz.com/papers/git-horror-story
https://help.riseup.net/en/security/message-security/openpgp/best-practices
http://keyring.debian.org/creating-key.html
https://wiki.debian.org/Subkeys

> I have written a a patch to comment out this vars

You might want to adopt the upstream patch for this:

https://github.com/uditha-atukorala/psocksxx/commit/8c94cd9e7fe22ee6411bc9ed07419f4236577ea8.patch

> > $ cppcheck --enable=all -j8 --quiet -f .
...
> No changes

Please do forward the warnings upstream.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: