[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#745721: Name collision between libpinyin and libzhuyin (Was: Bug#745721: [Pkg-ime-devel] Bug#745721: RFS: libzhuyin/0.9.93-1)



2014-10-01 1:38 GMT-03:00 ChangZhuo Chen (陳昌倬) <czchen@gmail.com>:

Hi!

> Do you use the tarball from github? The tarball from github does not
> contain data file used by libzhuyin, so upstream suggested using tarball
> from sourceforge [1].


Yes, I used the GitHub because your d/copyright, in Source field,
points to GitHub. You need fix it or add a Comment field to say that
the 0.9.99.20140929 was got from SF.


>> 3. d/copyright: there are new authors and dates in new upstream code.
>> You need to review all files Use 'grep -sriA25 copyright * | less' to
>> help you.
>
> I don't find any new copyright not listed in d/copyright except from
> "FSF" and "X Consortium". Both "FSF" and "X Consortium" copyright are in
> autotools generating files, so I think I don't need to list them, right?


You are right. I think that the GitHub code is different. Or a mistake
from me. Sorry.


> The "2002-2006 James Su <suzhe@tsinghua.edu.cn>" does not present
> anywhere except AUTHORS file, shall I keep it in d/copyright?


Yes. Is clear for me that the original code was developed by James.

I suggest you add an extra line in d/watch to search new versions in
GitHub too. You can use this (or similar):

https://github.com/libzhuyin/libzhuyin/releases
.*/archive/v?(\d\S+)\.tar\.(?:bz2|gz|xz)

Cheers,

Eriberto


Reply to: