[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#763540: Review of psocksxx/0.0.5-1



Hello Harlan,

first thanks for reviewing psocksxx.

Am Dienstag, den 30.09.2014, 22:18 -0400 schrieb Harlan Lieberman-Berg:
> Hello Jörg!
> 
> I took a look at psocksxx, and it looks pretty good!  A couple minor
> things that need to be changed:
> 
> - The section "comm" is meant for management of modems, especially ones
> connecting through POTS.  The section for libpsockxx0 should probably be
> "libs".
Ok changed

> - Because there are autotools files included inside upstream's tarball,
> you should run debhelper with "--with autoreconf" to run dh_autoreconf.
> Please note, "--with autoreconf", you don't need to (and shouldn't) run
> dh with "--with autotools_dev".
> 

d/control:
remove Build-Depends: autotools_dev
add Build-Depends:  dh-autoreconf

d/rules:
change to --with autoreconf

Package is uploaded to mentors[1].

> Thanks for packaging psocksxx for Debian!
> 


CU
Jörg

[1] http://mentors.debian.net/debian/pool/main/p/psocksxx/psocksxx_0.0.5-1.dsc

-- 
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8  EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56

Jörg Frings-Fürst
D-54526 Niederkail

Threema: SYR8SJXB

IRC: j_f-f@freenode.net
     j_f-f@oftc.net





Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: