Control: owner -1 ! Hi Jörg, On 26-12-14 20:48, Jörg Frings-Fürst wrote: > I am looking for a sponsor for my package "xmlrpc-c" I am willing to help, review below is incomplete yet though (just scanned the changes once). > Alternatively, one can download the package with dget using this command: > > dget -x http://mentors.debian.net/debian/pool/main/x/xmlrpc-c/xmlrpc-c_1.33.15+svn20141223~2672-1.dsc I use the git repository. I assume it is the same. Ironically, upstream just (15 hours ago) seems to have released 1.33.15 as tar ball. > * New debian/patches/200-test_port.diff: > - Change port for testing from 8080 to 7890 (Closes: #722503). I am missing some background, either in the bug or in the patch file. Why do you think hard coding 7890 is any better than 8080? And why do you consider this "Forwarded: not-needed"? Michael suggested to try multiple ports instead of relying on one port and I think upstream should be interested in such a patch. > * New debian/patches/005-xmlrpc_example.diff: > - Backport from upstream release 1.34.0 (Closes: #524550). If you still want me to upload your current package, could you add a source URL to the DEP5 header? The bts seems to say it should be here: http://sourceforge.net/p/xmlrpc-c/code/2491 but with that commit I don't see any content there. At least mention the proper revision in the headers. Also, the patch seems to fix more than just the bug in the bts. Please document what it is supposed to fix. > * New missing debian/xmlrpc-c-config.man and debian/xmlrpc.man. You created these files with help2man. I prefer it when you do this at build time, so that the man page stays up-to-date. I think you can tweak the settings of help2man to not add the date and your name. Other (random) remarks: Please target experimental during the freeze, unless you are fixing something that needs to go into jessie. Just wondering (haven't check yet), but you only add symbols files for amd64 and i386. Is this working correctly with the other archs? Or are they going to be more strict as a result? Please separate your commits to git to ease review and understanding. I don't understand why you created a "new upstream release". As far as I see it the only change is the version number and the distclean target in the Makefile. No further changes in the files that you decided to keep around. Paul
Attachment:
signature.asc
Description: OpenPGP digital signature