Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Hi,
> You should sometime read them
I have already read them many times in random order;
I will browse those again from start to begin to see if i missed
something important.
> As [1] is emtpy, I will be a little more verbose below, apologizes if I
> tell you something you already know.
Indeed. I have till now very little experience with packaging.
I just built some dummy ones with equivs.
> -> Change the Orphaning Bug to an Intent-To-Adopt-Title (ITA:) one and
> set yourself as owner (see https://www.debian.org/devel/wnpp/#howto-o
> and https://www.debian.org/Bugs/server-control; bts(1) is also a useful
> tool for manipulating bug status)
Done, I wish I knew bts existed before.
> -> Close the Bug in your d/changelog. (some entry like "New maintainer
> (Closes: #763888) -- (d/ is short for the debian/ directory in your
> package)
Ok
> -> Set yourself as Maintainer in d/control (and remove the likely
> inactive Uplpoader; he can be added in case of again)
Ok
> > I already solved 3 bugs, they will be automaticaly closed by the amended changelog.
> Thats the way to go. If you like, you can also tag those bugs "pending"
In fact, those fixes are already included in the last upload from Marcin
that is already in sid.
(cruft-ng)
> Just one remark: Depends should be only used when
> appropriate -- refer to Policy §7.2 -- so only if cruft-ng requires
> cruft to operate)
It does well requires all the _rules_ from the explain/ & filters-unex/
directories. The proper way to do it would be to have an
arch-indepedant "cruft-data" package with theses rules,
with two arc-dependant "cruft" & "cruft-ng" that depend on this.
Though, this is much work; I guess that people willing to rewrite
cruft could also just do a "git clone ; cd ; make" to try it out.
> NM is to become a DD.
Ok, I mixed it up; I thought taht was needed to recognize the gpg key.
>> (Lintian Error )
> This error will go away after you adopted the package (as described
> above)
>
Ok
> -> d/changelog:
>
> There was an upload Oct3 -> you need to rebase your d/changelog to
> include the changes from 0.9.17
> (skip the unreleased nmu)
Ok, I did the rebase, the nmu is gone
> Standard Version 3.9.6 is out ;-)
Ok
> Regarding VCS-*, they need some update as you need to keep them actual
Marcin transfered me the "root" GitHub repository
after I deleted my fork, I adapted the URL everywere.
> (Note: Seems that Marcin did not push the tag for 0.9.17 -- please make
> sure to tag this release. Tool recommendation: git-buildpackage
I set the tag.
> -> d/copyright
>
> Comment: should go, not needed.
>
> You need to add your name to the "*" section
> (as you are also becoming upstream, I guess. Its a native package
> afterall :))
Ok, I just didn't want to rush it/hurt people feelings;
It's nothing technical. This is correct now.
I removed the links to the wiki & alioth page;
those are not much usefull anyway.
> -> d/cruft.lintian-overrides
> Please remove the lines when no longer needed, not just only comment it.
Ok
> -> d/docs is empty
> Remove file if not needed.
Ok
> -> d/dirs *might* not be needed, as debhelper will create the dirs for
> you usually. So check if can be cleaned up
I've forgotten this little bit in my last upload to mentors.
Only the empty folders should be there. (/var/... & /etc...)
> Ok, the list is not really long. Good job!
> Please update the package, replay to this mail and say what you changed,
> put it to mentors, and give me a ping.
https://mentors.debian.net/package/cruft - 2014-10-06 05:09
>
> --
> Tobi
Thanks for the review
Alexandre
Reply to: