Bug#762015: Subject: RFS: s3fs-fuse/1.78-1 [ITP #601789] -- FUSE-based file system backed by Amazon S3
Jakub, thank you for a review, answers inline
>> .orig.tar.gz is not bitwise-identical to the one uscan downloads. Why?
It seems git-buildpackage has repacked the tarball, I've done new
upload with the correct orig tarball.
>> Current standards version is 3.9.6. (But beware that Lintian doesn't know about it yet!)
I've check the package against new standards version, no changes required.
>> You don't have to specify full debian-policy version in the Standards-Version field. Only the first three components (that is, "3.9.5" or "3.9.6") have to be specified. (Policy §5.6.11)
I used to write the full version in all my packages. If this is a
problem, I'll fix it.
>> I think it's customary not to put any space between "(" and "=" in relationship fields.
Fixed.
>> There are some stray(?) 0x81 bytes in doc/man/s3fs.1 (line 74) and src/s3fs_util.cpp (line 878).
Thank you, I haven't noticed them. I've prepared a patch and sent it
to upstream already.
As for spelling errors, I've sent the request to upstream author. Some
of those found by spellintian seem to be false positives ("ressize"
variable meant "resource size"). [1,2] For now I have added quilt
patch for stray chars but left spelling errors to be merged by
upstream.
[1]: https://github.com/s3fs-fuse/s3fs-fuse/pull/62
[2]: https://github.com/s3fs-fuse/s3fs-fuse/pull/63
2014-09-26 14:28 GMT+03:00 Jakub Wilk <jwilk@debian.org>:
> [I don't intend to sponsor this package. Sorry!]
>
> * Andriy Senkovych <jolly_roger@itblog.org.ua>, 2014-09-17, 22:00:
>>
>>
>> http://mentors.debian.net/debian/pool/main/s/s3fs-fuse/s3fs-fuse_1.78-1.dsc
>
>
> .orig.tar.gz is not bitwise-identical to the one uscan downloads. Why?
>
> Current standards version is 3.9.6. (But beware that Lintian doesn't know
> about it yet!)
>
> <nitpicking mode="extreme">
>
> You don't have to specify full debian-policy version in the
> Standards-Version field. Only the first three components (that is, "3.9.5"
> or "3.9.6") have to be specified. (Policy §5.6.11)
>
> I think it's customary not to put any space between "(" and "=" in
> relationship fields.
>
> </nitpicking>
>
> There are some stray(?) 0x81 bytes in doc/man/s3fs.1 (line 74) and
> src/s3fs_util.cpp (line 878).
>
> codespell(1) finds a bunch of typos:
>
> README:64: happend ==> happened
> src/s3fs_util.cpp:499: infomation ==> information
> src/s3fs_util.cpp:501: infomation ==> information
> src/s3fs_util.cpp:535: infomation ==> information
> src/s3fs_util.cpp:537: infomation ==> information
> src/openssl_auth.cpp:134: destory ==> destroy
> src/curl.cpp:532: existance ==> existence
> src/curl.cpp:1908: occured ==> occurred
> src/curl.cpp:3475: charactor ==> character
> src/curl.cpp:3479: charactor ==> character
> src/curl.cpp:3514: charactor ==> character
> src/curl.cpp:3516: Charactor ==> Character
> src/s3fs.cpp:2043: responce ==> response
> src/s3fs.cpp:2565: occured ==> occurred
> src/s3fs.cpp:2691: Destory ==> Destroy
> src/s3fs.cpp:2947: occured ==> occurred
> src/s3fs.cpp:2955: Destory ==> Destroy
> src/s3fs.cpp:3903: compatability ==> compatibility
>
> spellintian[0] finds a few more:
>
> src/fdcache.h: ressize -> resize
> src/fdcache.cpp: ressize -> resize
> src/s3fs.cpp: ressize -> resize
> src/curl.h: failuer -> failure
>
> [0] https://bitbucket.org/jwilk/spellintian
>
> --
> Jakub Wilk
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact
> listmaster@lists.debian.org
> Archive: https://lists.debian.org/20140926112824.GA3584@jwilk.net
>
Reply to: