[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#752116: RFS: drmips/1.2.2-1 [ITP]



Hi Bruno,

We have a little issue yet. I d/copyright:

Files: src/pc/DrMIPS/src/com/jtattoo/plaf/BaseInternalFrameTitlePane.java
       src/pc/DrMIPS/src/com/jtattoo/plaf/BaseTabbedPaneUI.java
       src/pc/DrMIPS/src/com/jtattoo/plaf/BaseTitlePane.java
Copyright: 2003 Sun Microsystems, Inc.
License: GPL-2.0+

You must list Sun and Software-Entwicklung too because both have
copyright rights.

Cheers,

Eriberto


2014-09-26 16:42 GMT-03:00 Bruno Nova <brunomb.nova@gmail.com>:
> I just found and fixed a small error in the .desktop file, so I uploaded a
> new package.
>
> And the upstream changelog is indeed detected in Debian. But you still
> should check it.
>
> 2014-09-26 19:50 GMT+01:00 Bruno Nova <brunomb.nova@gmail.com>:
>>
>> I uploaded a new package to Mentors (also updated the source tarball).
>> I think I fixed all issues/suggestions.
>>
>> > src/pc/DrMIPS/src/com/jtattoo/* was copyrighted in 2002, not 2012.
>> > Please, use '2002 and later', not '2012+'. I suggest the original text
>> > '2002 and later by MH Software-Entwicklung'.
>>
>> Thank you! Don't know how I failed that.
>>
>> >>> 5.d/links: I didn't understand your intend with this file.
>> >>
>> >> I added a patch to the package to install the PDF manuals to
>> >> /usr/share/doc/drmips/manuals, and used the debian/links file to create
>> >> a
>> >> link from /usr/share/drmips/doc to /usr/share/doc/drmips/manuals (this
>> >> is
>> >> acceptable, right?).
>> >
>> >
>> >Ok, I understand your concern but it is unusual. All packages put
>> > their docs in /usr/share/doc/. I suggest to remove this link. But I
>> > won't impose this.
>>
>> I changed to source code of the simulator. Now, if the "./doc" folder
>> doesn't exist, it opens the folder where "make install" installs the manuals
>> to (if it exists).
>> So, debian/links and the patch were removed, and this issue is solved.
>> (Should have done this earlier)
>>
>> > Ok!
>> >
>> > You can remove the d/docs files because upstream changelog will be
>> > automaticaly detected by DebHelper.
>>
>> That's interesting. I compiled the package in Ubuntu, and the upstream
>> changelog was not detected automatically.
>> It seems dh_installchangelogs was changed in Ubuntu to not install the
>> upstream changelog:
>> https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/637176
>> I still removed the debian/docs file. Please check if the upstream
>> changelog is detected in Debian. I didn't have the time to test this in
>> Debian yet.
>>
>> --
>> Bruno Nova
>
>
>
>
> --
> Bruno Nova


Reply to: