Bug#749096: RFS: karlyriceditor/1.11-1 [ITP]

[Eriberto Mota <eriberto@debian.org>]

Hi Martin!

Thanks for changes. Uploaded.

Cheers,

Eriberto

2014-09-20 8:58 GMT-03:00 Martin Steghöfer <martin@steghoefer.eu>:
> Hi Eriberto,
>
> Thank you for your time and attention!
>
> I've uploaded a new version to git and mentors that incorporates your
> suggested changes:
>  * https://github.com/martin-steghoefer/debian-karlyriceditor
>  * http://mentors.debian.net/package/karlyriceditor
>
>
> Eriberto Mota wrote:
>>
>> 1. Update the package to use DH 9, instead DH 8.
>
>
> Done in
> https://github.com/martin-steghoefer/debian-karlyriceditor/commit/e2aa0ed5
>
>> 2. d/control:
>>      - Change priority from extra to optional.
>
>
> Done in
> https://github.com/martin-steghoefer/debian-karlyriceditor/commit/296f209d
>
>>      - Break the Build-Depends in some lines to make visualization easier.
>
>
> Done in
> https://github.com/martin-steghoefer/debian-karlyriceditor/commit/b0949627
>
>> 4. d/rules:
>>      - Remove the initial useless comments [...].
>
>
> Done in
> https://github.com/martin-steghoefer/debian-karlyriceditor/commit/9416a63c
>
>>      - Change the four export lines (CPPFLAGS, CFLAGS, CXXFLAGS and
>> LDFLAGS) to 'export DEB_BUILD_MAINT_OPTIONS = hardening=+all'. You can
>> check the results using the command 'blhc --all
>> karlyriceditor_1.11-1_amd64.build'
>
>
> Nice trick, thanks! Not only did this make the debian/rules file more
> readable, but it also added some extra hardening flags that were not
> included before. I hadn't checked the hardening with blhc before, only with
> lintian - and it seems that lintian only checks for some basic hardening
> flags (probably because it is designed to only check the pure package, but
> not the build log that may not always be available).
>
> Done in
> https://github.com/martin-steghoefer/debian-karlyriceditor/commit/4fdf9268
>
>
> Thank you for your review! Anything else I can do to accelerate the sponsor
> search?
>
> Cheers,
> Martin
>