Bug#760884: Aw: Bug#760884: RFS: astroquery/0.2.1-1 [ITP]

["Steffen Möller" <steffen_moeller@gmx.de>]

Hello,

> Thank you for the review.
> > The latest version is 0.4.
> Where have you found this? On both Pypi and Github, the latest release 
> is 0.2.2.

The commment may refer to astropy, which is at 0.4.1. That is an associated
project but not shipping astroquery itself. For astroquery,
astropy points to http://www.astropy.org/astroquery/ and the zip generated
for that declares itself as 0.2.2. Is there any other version declared
within the source tree? Otherwise 0.2.2 seems just right.

> > Please add a .patch extension to the patch file name.
> > You should add information for debian/* to debian/copyright.
> > Is it really necessary to rm astroquery.splatalogue in override_dh_python* and not in override_dh_(auto)?_install?
> I will correct this.
> > Also, I couldn't actually build the package because of missing
> > python3?-astropy-helpers.
> Version 0.2 needed astropy-helpers to build, so I asked the maintainer 
> of astropy to package astropy-helpers as well.
> The package is now in the NEW queue.
> However, it seems that astropy_helpers is now included in the astroquery 
> source tarball.
> Maybe I should remove the dependencies and use the bundled version. What 
> is your opinion about this?

Is it right or wrong to have the astropy-helpers shipping with astroquery?
Who else is sharing that same astropy-helper module?
>From my immediate perception I would tend to prefer the dependency and
even remove the helpers from the astroquery source tree.

Best,

Steffen