[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#758232:



Hi Tobias,

Thanks for the comments.
I did a new upload of kvmcs_0.4.5-1 and everything is adjusted.
There are also some changes in the upstream software.

The changes are:
- log files as package names (from UpstreamGuide)
- log files are deleted in postrm (from UpstreamGuide)
- changes in procedure (installation experience on a new site)
- d/rules boilerplate text deleted
- d/watch is working (version tags in gitorious)
- ITP bug created
- ITP bug closed in d/changelog
- dependency of lyx moved to Build-Depends-Indep

Willem
 

Op Sun, 31 Aug 2014 22:48:26 +0200
schreef Tobias Frost <tobi@debian.org>:

> Hi Willem,
> 
> here's a short review; I do not intend to sponsor this package.
> 
> You are also upstream, aren't you? Then I suggest reading
> https://wiki.debian.org/UpstreamGuide (I always write that; However, I
> did not spot any common errors :))
> 
> Reviewing the pacakge (unordered list)
> -> You need to file an ITP bug 
> -> When you upload a package for the first time to Debian, the only
> changelog entry is "Intial Release (Closes #your-itp-bug)
> -> (The Debian-part of the package-version is then also -1 )
> 
> -> d/rules --with-quilt is not needed. See man dh_quilt_patch
> 
> -> d/watch does not work.
> 
> -> Please remove the boilerplate-text (line2-7 from d/rules
> 
> -> If possible, move lyx to Build-Depends-Indep as it is only needed
> for buiding arch:all doc pacakage. This saves severval indirect
> B-Ds...
> 
> 


Reply to: