Bug#761074: RFS: cputool/0.0.7-1 [ITP]
On 09/10/2014 08:22 PM, Tobias Frost wrote:
Control: owner -1 !
Tags: pending
Hi Nigel,
The quality of the package is very good;
Thanks guys :), I will further make a note of the below and make sure I
keep them in mind for next time.
Thanks for your input Tobias, I really appreciate the time you've taken
to point out the below.
I just saw a few nitpicks which I'd ask you fix before I upload it:
-> d/copyright
- please join the lines AllWorldIT and your contact (as it does not
describe a new copyright)
- mind to add a Upstream-Contact Header?
If I add the upstream contact, would you still like the contact on the
copyright line? The reason I added it was to show the upstream contact.
- Comment (line 3) is not needed, please remove it (its in d/control)
Removed.
- there are extra ",s" after the years in line 8 and 12
Could you clarify this for me Tobias, I must be missing something, I
copied an example that Eriberto gave me here...
http://metadata.ftp-master.debian.org/changelogs/main/s/sentinella/unstable_copyright
- has a final blank line
Removed.
-> d/control
- I'd prefer only to override when necessary. In this case, please
remove the file using d/clean.
- please use dh_autoreconf
Sorted. I now have this, I hope its what you were referring to...
***
$ cat rules
#!/usr/bin/make -f
%:
dh $@ --with autoreconf
***
Thanks again for your time!
-N
Reply to: