Bug#751009: RFS: ppp-gatekeeper/0.1.0-201406111015-1 [ITP]
Hi Nigel,
Sorry but I was mistaken.m Your mentors page has several versions of
the package. I reviewed your package after a hard day and I caught an
old version. Can you upload a new version? I saw that you accepted
some considerations and I will need review all package again. Please,
fix the package and reupload.
Thanks for your work.
Cheers,
Eriberto
2014-09-07 9:53 GMT-03:00 Nigel Kukard <nkukard@lbsd.net>:
> On 09/07/2014 04:12 AM, Eriberto Mota wrote:
>>
>>
>>
>> Hi Nigel,
>>
>> Please:
>>
>> 1. d/changelog: you didn't put an ITP reference. Please, read it[1] to
>> you see how to make an initial changelog.
>>
>> [1] https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#changelog
>
>
> The d/changelog file only contains the following...
> **
> pp-gatekeeper (0.1.0-201406111015-1) unstable; urgency=low
>
> * Initial release. (Closes: #758696)
>
> -- Nigel Kukard <nkukard@lbsd.net> Thu, 04 Sep 2014 07:52:55 +0000
> **
>
> I modified this according to the reply in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751009#56
>
> Could you please clarify how this is incorrect so i can fix it?
>
>>
>> 2. d/copyright:
>> - You need to add the section 'Files: debian/*' because you can
>> wish make a Debian revision without an upstream revision.
>
>
> Could you please clarify this. Upstream (me) already has a debian/
> directory, would these files not fall under the Files: * section currently
> in d/copyright?
>
> Do you want me to put the following section in regardless of the above?
> *
> Files: debian/*
> Copyright: 2014 Nigel Kukard
> License: GPL-3+
> *
>
>> - The information in d/copyright is different from upstream code.
>> There is a license file saying GPL-2. However, ppp-gatekeeper file
>> says 2008-2014 GPL-3+.
>
>
> The file ppp-gatekeeper correctly states GPL-3+ , the d-copyright file
> correctly states GPL-3+, the upstream LICENSE file also states GPL-3+.
>
> Could you please clarify which file you are referring to?
>
>
>>
>> 3. d/ppp-gatekeeper.dirs: remove etc/modprobe.d because
>> d/ppp-gatekeeper.install will create it.
>
>
> I'll sort this out, thanks for pointing it out.
>
>
>>
>> 4. d/ppp-gatekeeper.install: you are installing a file inside
>> /etc/shorewall. However, shorewall is a suggestion, not a dependency.
>> So, you must put contrib/start.shorewall in
>> usr/share/docs/ppp-gatekeeper/examples and write a d/README.Debian to
>> explain about how to use this file.
>
>
> I'll sort this out, thanks for pointing it out.
>
>
>>
>> 5. d/rules:
>> - override_dh_installdocs: don't install AUTHORS as docs. This
>> information should be provided by d/copyright. I suggest to use
>> d/ppp-gatekeeper.docs ($ man dh_installdocs).
>
>
> I already removed this from my last upload, as indicated by
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751009#56 as it does not
> contain any useful information for a user.
>
>
>> - override_dh_clean: I suggest to use d/clean ($ man dh_clean).
>
>
> Already fixed in the latest upload as indicated in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751009#56
>
>> - You are creating/deleting a manpage.1 but the correct level is 8.
>
>
> I have corrected this, thank you very much for pointing it out.
>
>>
>> 6. You have Lintian messages to solve:
>>
>> W: ppp-gatekeeper: new-package-should-close-itp-bug
>
> Already fixed as per above.
>
>> E: ppp-gatekeeper: description-is-pkg-name PPP Gatekeeper
>
>
> Already fixed in latest upload, mentors lintian no longer shows this
> message.
>
>> I: ppp-gatekeeper: extended-description-is-probably-too-short
>
>
> I already expanded the description. I'm not seeing this message on local or
> mentors, could you indicate where you are seeing it?
>
> -N
Reply to: