Bug#744823: RFS: gnuais/0.3.0-1 [ITP]
2014-09-02 15:34 GMT-03:00 Ruben Undheim <ruben.undheim@gmail.com>:
> Hi Eriberto,
Hi!
> 2. Fixed line break before column 80.
> Added VCS-control pointing to branch on github where debian/
> folder is kept. Vcs-Browser points to the correct branch (debian) on
> github, but I didn't get Vcs-Git to point to a specific branch, but
> it points to the correct git-repository.
The Vcs-Git must be:
Vcs-Git: git://github.com/rubund/gnuais.git -b debian
> 3. I've gone through all Copyright-lines in all the files and I hope I
> have included all. However, after I put the licenses separately below,
> a few lintian information warnings appeared. I'm not sure what is best
> to do here.
There are errors.
a. Some files in src/ are GPL-2/LGPL-2, not GPL-2+/LGPL-2+. You must
separate these files. You can use 'grep -sriA20 copyright src/*' to
check.
b. Remove the '(pick any you like)'. It will clean your lintian. But,
there an error yet...
c. You must put the complete text for all licenses and pointing to
/usr/share/common-licenses when needed. You can use these examples:
License: Artistic
This program is free software; you can redistribute it and/or modify it
under the terms of the "Artistic License" which comes with Debian.
.
THIS PACKAGE IS PROVIDED "AS IS" AND WITHOUT ANY EXPRESS OR IMPLIED
WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES
OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
.
On Debian systems, the complete text of the Artistic License
can be found in "/usr/share/common-licenses/Artistic".
License: BSD
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. Neither the name of the University nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE HOLDERS OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
LGPL-2+ and GPL-2+ are ok. But, in your case, you must put: "Licese:
GPL-2 or GPL-2+".
> 4. NEWS removed. gnuais.conf-example installed by gnuais.examples.
> Patch added so that the program knows where to find the example
> configuration file since it is used as a template the first
> time gnuais runs. (01_conf_location.patch)
No, you can't install/change files in /usr/local. Fix it.
> 5. NEWS removed. OpenStreetMap is provided by libosmgpsmap which is in
> d/control. I haven't written a README.Debian file since I don't think
> there is anything special that applies for Debian users
> compared to other users.
Are you sure about this? Please, see:
$ dpkg -I ../gnuais_0.3.2-1_amd64.deb
[...]
Depends: libasound2 (>= 1.0.16), libc6 (>= 2.14), libcurl3 (>=
7.16.2), libmysqlclient18 (>= 5.5.24+dfsg-1), libpulse0 (>= 0.99.1)
> 6. I've added an icon for gnuaisgui. I have not added for gnuais since
> it is a command line utility only.
So I think that no need a gnuais.menu file... Why put it in menu?
> 10. I've gotten rid of the hardening-no-fortify-functions with 02_cflags.patch.
> The "debian-watch-may-check-gpg-
> signature" is still there. I hope
> I don't have to fix that one. I may look into that later.
No. To solve it you will need a GPG signed file from upstream. We can
upload with this Lintian. But I would like to suggest you to ask for
upstream to add a GPG signature for next release. To see more details,
'$ man uscan' (search for pgpsigurlmangle). To sign the tarball, the
upstream can use 'gpg -ab <tarball_name>'.
Cheers,
Eriberto
Reply to: