Control: owner -1 ! Control: tags -1 +pending Hallo Benedikt, here's a review: -> Package does not build, misses at least a B-D on libusb-1.0-0-dev and pkg-config -> as the manpage is created using help2man, you should regenerate it during build -> you do not need to set a link from the debian manpage, but you can directly install the manpage. (See 5.16 of the new maintainers' guide) -> You should dh_autoreconf instead of autotools-dev (as you also use automake), see https://wiki.debian.org/Autoreconf#Using_autotools-dev -> d/changelog Debian version starts at "-1" for new packages, and state only "Initial Release (Closes #ITP-Bug)" -> please use spaces for indentation in d/copyright -> same for postinst -> don't install README -- is has no additional information and only duplicates the package description -> you need to depend on adduser in your binary pacakge. (The review might be incomplete as I have to stop now; please fix the above and re-upload to mentors, then give me a ping -- tobi On Thu, 2014-08-28 at 23:36 +0200, Benedikt Wildenhain wrote: > Hi Baird, > > On Thu, Aug 28, 2014 at 09:19:26AM +1000, Riley Baird wrote: > > Indoor Air Monitor, so I can't test it. However, looking over your > > package, afaict everything is fine, except you should remove the > > unnecessary comments in d/rules and d/watch. > thanks for the hint, I fixed that. > > Kind regards, > Benedikt Wildenhain
Attachment:
signature.asc
Description: This is a digitally signed message part