[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#751009:



Hi Nigel,

(I do not intend to sponsor this package, sorry.)

I had a few minutes, so here is a very short review (for sure not
complete:)

You are also upstream, aren't you? Then I suggest reading
https://wiki.debian.org/UpstreamGuide
(So you should for example consider removing the debian directory from
your repository; it will be hard for you to keep that in sync... :))

d/changelog:
for a new package its only "Initial release (Closes #xxxxxx)"; delete
the rest. 
There's should be an empty line between the "header" line and the
entries
Hint: Use dch(1) to create your d/changelog, don't do it manually

You need to remove your logfiles when the package is purged.
(using a postrm script) See policy 10.8 

There is a linitian problem with the long description, refer also to
policy 3.4.1

d/rules
I'd suggest not to override targets if there are other means, like
d/clean instead of override_dh_autoclean

AUTHORS and TODO needs not to be installed in the binary package, as it
does not contain information useful to the user.

Thanks!

--
tobi


Reply to: