Bug#755410: RFS: python-xmp-toolkit/2.0.1-1 [ITA] -- Python library for XMP
Eriberto,
thank you very much for reviewing my package.
On 28.08.2014 21:49, Eriberto Mota wrote:
1. d/copyright says that upstream copyright years are 2008-2009.
However, the upstream changelog has newer dates. Please, update the
years.
The changelog spans up to 2.0.0 of 2013.
I've rechecked the repo and found that our tarball 2.0.1 is actually a
beta (Git releases: "2.0.1 release preparation"). AAMOF the repo
contains an updated changelog with infos on release 2.0.1 (spanning to
2014).
So, I've updated deb/copyright to the actual year of the code, 2014.
Further, I would like to package the latest git rev. as
2.0.1~git0000000-1, do you agree?
I've also updated an Upstream-Contact email address according to AUTHOR.
2. Remove the useless file d/source/options.
Yes, that's obselete. Removed it.
3. A problem: after the build of the binary python-libxmp-doc, the new
files usr/share/doc/python-libxmp-doc/html/_static/{basic,default}.css
have this header:
* Sphinx stylesheet -- default theme.
*
* :copyright: Copyright 2007-2014 by the Sphinx team, see AUTHORS.
* :license: BSD, see LICENSE for details.
It is an inedit situation for me, but the license must be placed at
d/copyright. So, I suggest put it in d/copyright and add a field
'comment'[1] to explain about this.
[1] http://dep.debian.net/deps/dep5/#fields
I've added that to deb/copyright. License details I've taken from
LICENSE of the python-sphinx source package.
4. Note that your package has new binaries (.deb) and will be NEW.
Yes, alright.
Thanks for your work. Your packaging is very good.
Thanks for encouraging, nice!
For the fresh build, please cf.
http://lists.alioth.debian.org/pipermail/python-modules-commits/2014-August/029615.html
http://svn.debian.org/viewsvn/python-modules/packages/python-xmp-toolkit/trunk/
http://www.danielstender.com/buildlogs/python-xmp-toolkit_2.0.1-1_amd64.build
http://mentors.debian.net/debian/pool/main/p/python-xmp-toolkit/python-xmp-toolkit_2.0.1-1.dsc
Greetings,
Daniel Stender
--
http://www.danielstender.com/blog/
PGP key: 2048R/E41BD2D0
C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0
Reply to: