Bug#759296: RFS: psensor/1.0.4-1
Very good! Thanks!
I would like to suggest you to add a GPG signature for your upstream
code in next release. To see more details, '$ man uscan' (search for
pgpsigurlmangle). To sign your tarball, you can use 'gpg -ab
<tarball_name>'.
Cheers,
Eriberto
2014-08-29 5:49 GMT-03:00 jeanfi <jeanfi@gmail.com>:
> Hello Eriberto,
>
> Thanks for your review!
>
> I have uploaded to mentors an updated version of the package fixing
> the raised issues.
>
> On 08/28/2014 04:55 PM, Eriberto Mota wrote:
>> 1. d/control: I will leave you decide it. But, can you remove the
>> isolated dot at end of each long description? I will accept a "no".
>> ;-)
> Fixed [1]
>
>>
>> 2. d/copyright: please, convert this file to 1.0 format. It is easy
>> and you can use this example[1]. Please, use the exact text of the
>> example for the license.
>>
>> [1] http://sources.debian.net/src/iwatch/0.2.2-3/debian/copyright/
>
> Fixed [2] [3]
>
> Notes:
> - added missing jquery copyright even if it is not installed, I believe
> it must be present just because it is in the upstream tarball
> - added Upstream-Contact field unlike your example
>
>> 3. d/control: please, remove all useless comments:
>>
>> ----------------------------------------
>> # -*- makefile -*-
>> # Sample debian/rules that uses debhelper.
>> # This file was originally written by Joey Hess and Craig Small.
>> # As a special exception, when this file is copied by dh-make into a
>> # dh-make output file, you may use that output file without restriction.
>> # This special exception was added by Craig Small in version 0.37 of dh-make.
>>
>> # Uncomment this to turn on verbose mode.
>> ----------------------------------------
> I guess you mean debian/rules.
>
> Fixed [4].
>
> Regards,
> JeanFI.
>
> [1]
> http://wpitchoune.net/gitweb/?p=psensor-pkg-debian.git;a=commitdiff;h=2882f485e1f3fc036a14f7c23acd699e976068c1
> [2]
> http://wpitchoune.net/gitweb/?p=psensor-pkg-debian.git;a=commitdiff;h=ef1a2d394021c73809695b31cae00dff4ba7762b
> [3]
> http://wpitchoune.net/gitweb/?p=psensor-pkg-debian.git;a=commitdiff;h=618915398bfc474a55da38635b20af656fddebf4
> [4]
> http://wpitchoune.net/gitweb/?p=psensor-pkg-debian.git;a=commitdiff;h=9129ba168b7b8ab8883513fb06cc64cf4ed6e66b
>
>
Reply to: