Bug#752897: (no subject)
>Hi Łukasz, Gianfranco,
hi Tobi!
>I've just got 30 minutes for a short review...
really appreciated :)
-> d/patches: the patches need a dep3-header and needs to
ack, changed
-> d/changelog should be just "Initial Release."
ok
-> d/control VCS-Browser does not work (404)
-> d/control VCS-bzr does not work (not found)
yes, I think Lukasz will create them as soon as the package is accepted :)
-> d/control Pre-Depends - remove the trailing "," ; also on the Depends:
done
-> do you see a possiblity to move doxygen to Build-Depends-Indep?
done :)
-> there's lots of noise in the buildlog, always repeating that warning. Please try to patch it away...:
>cd /home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/src/core && /usr/lib/ccache/c++ -DLPP_BUILDING_LIB -Dlucene___EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -I/home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/include -I/home/tobi/mentors/lucene++-3.0.6/include -I/home/tobi/mentors/lucene++-3.0.6/src/core/include -fPIC -DLPP_HAVE_DLL -include "/home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/src/core/cotire/lucene++_CXX_prefix.hxx" -Winvalid-pch -o CMakeFiles/lucene++.dir/search/spans/SpanTermQuery.cpp.o -c /home/tobi/mentors/lucene++-3.0.6/src/core/search/spans/SpanTermQuery.cpp
In file included from <command-line>:0:0:
/usr/include/stdc-predef.h:59:1: warning: /home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/src/core/cotire/lucene++_CXX_prefix.hxx.gch: not used because `lucene' not defined [-Winvalid-pch]
#endif
^
this seems to be fixed in upstream
https://github.com/luceneplusplus/LucenePlusPlus/commit/a385bcf745bd9e04f2404a3613e0a6b6fe041302
https://github.com/luceneplusplus/LucenePlusPlus/commit/8c05fcd7a564888a485419d7e2fafa5e9f87e5c8
I honestly don't want to cherry-pick them, I would rather push upstream for a new release and drop all the debian patches at once.
Having new sublibraries in a package is a delta from upstream I don't want to have (Don't know if Lukasz has a different opinion on that), at least to only fix a build warning (I care so much about warnings, but I think the next release will happen really soon)
>Ok, otherwise it looks good; at least it seem up to now building fine...
>Please fix above, and I will do a final check of d/copyright (this cannot be done in 30 minutes...)
>For the VCS-*-fields, as you seems to work both on the package, I appreciate packaging using a VCS, so please do not drop the >VCS-fields.
>Please use something like git-buildpackage (I think there is a bzr-buildpackage). It needs not to be on a Debian service, though.
waiting for Lukasz feedback, for me it is just the same :)
(we can also fix this later I think)
>Thanks for your contribution!
thanks for the review!
cheers,
Gianfranco
Gianfranco
Reply to: