Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
Hi Joseph,
Thanks for making the package for Debian! I'm not a DD, so I can't
sponsor your package, but here's my review:
d/control:
-Don't put each dependency on a different line.
-In your description, you don't need to include a description of what
node.js is, rather, you can mention that your package makes use of node.js
d/copyright:
-Use the author's full name (Joaquim José F. Serafim) instead of their
Github username.
d/rules:
-Remove the commented lines; only keep what is necessary.
d/watch:
-Why have you used fakeupstream? Can it actually detect new upstream
versions, and if so, how? If not, then you should just make a watch file
with some comments explaining that upstream doesn't provide a
uscan-compatible method of getting releases.
README.md:
This is really upstream's problem, but the sample usage of
base64url.escape needs to have quotes around the input to run correctly;
furthermore all outputs should have quotes around them as well. Perhaps
you could patch this and then send the fix upstream?
Once you have done this, you may wish to contact the Debian JavaScript
Maintainers[1] to see if you can get one of them to sponsor your package.
Good luck in getting your package into Debian!
Riley Baird
Reply to: