Control: owner -1 ! Control: tags +pending Hi Łukasz, Gianfranco, I've just got 30 minutes for a short review... -> d/patches: the patches need a dep3-header and needs to -> d/changelog should be just "Initial Release." -> d/control VCS-Browser does not work (404) -> d/control VCS-bzr does not work (not found) -> d/control Pre-Depends - remove the trailing "," ; also on the Depends: -> do you see a possiblity to move doxygen to Build-Depends-Indep? -> there's lots of noise in the buildlog, always repeating that warning. Please try to patch it away...: cd /home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/src/core && /usr/lib/ccache/c++ -DLPP_BUILDING_LIB -Dlucene___EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -I/home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/include -I/home/tobi/mentors/lucene++-3.0.6/include -I/home/tobi/mentors/lucene++-3.0.6/src/core/include -fPIC -DLPP_HAVE_DLL -include "/home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/src/core/cotire/lucene++_CXX_prefix.hxx" -Winvalid-pch -o CMakeFiles/lucene++.dir/search/spans/SpanTermQuery.cpp.o -c /home/tobi/mentors/lucene++-3.0.6/src/core/search/spans/SpanTermQuery.cpp In file included from <command-line>:0:0: /usr/include/stdc-predef.h:59:1: warning: /home/tobi/mentors/lucene++-3.0.6/obj-x86_64-linux-gnu/src/core/cotire/lucene++_CXX_prefix.hxx.gch: not used because `lucene' not defined [-Winvalid-pch] #endif ^ Ok, otherwise it looks good; at least it seem up to now building fine... Please fix above, and I will do a final check of d/copyright (this cannot be done in 30 minutes...) For the VCS-*-fields, as you seems to work both on the package, I appreciate packaging using a VCS, so please do not drop the VCS-fields. Please use something like git-buildpackage (I think there is a bzr-buildpackage). It needs not to be on a Debian service, though. Thanks for your contribution! -- tobi
Attachment:
signature.asc
Description: This is a digitally signed message part