Bug#753487: RFS: stda/1.3.1-1 -- new upstream release (package already in Debian)
Hi Eriberto,
On Fri, 22 Aug 2014, Eriberto Mota wrote:
2014-08-22 12:00 GMT-03:00 Dimitar Ivanov <drimiks@freeshell.de>:
Hello Eriberto,
Hi!
I implemented most of the changes you requested.
1. d/compat: change to 9.
Done.
Not done. I can see 7.
Fixed.
2. d/control:
- Set 9 to debhelper.
- Consider change the priority to optional. Please, read it[1].
- Create a VCS to control your debian/ versions. You can use github
or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control.
- Add a punctuation in each item in long description.
[1] https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities
Done, except the VCS stuff.. Because I'm not sure what kind of a
VCS-entiries should I define in d/control, I'll write you a separate mail
related to what exactly and how it should be version-controlled. May be
presently you can review the new package which don't include VCS-entries,
and later I can produce a new debian-release where Vcs-Browser and
Vcs-{Git|Svn|Cvs} are defined in d/control.
Sorry, but when I said punctuation, I meant to put a dot in end of
each line. Example:
* maphimbu - histogram builder for 1-d numerical and text data.
* mintegrate - evaluate average/sum/integral/derivative of 1-d numerical data.
Well, but a short description is not a complete sentence, why should one
put a dot there? In my opinion it should stay as it is - see for example:
[1] http://sources.debian.net/src/tcputils/0.6.2-9/debian/control/
[2] http://sources.debian.net/src/cutils/1.6-3.1/debian/control/
Or maybe a semicolon ';' can be put at the end..
You really need a VCS. It is very important to keep the package
control across the versions. I suggest to use GitHub (easy). Please,
put 'github tutorial' in Google. You need put, at least, the debian/
directory under the VCS control. In d/control you need add Vcs-Browser
and Vcs-Git fields. You can see an example here:
http://sources.debian.net/src/mac-robber/1.02-3/debian/control/
Ok, how about hosting a repository of the stda-package on Alioth within
the collab-maint project: would you like to support this? Otherwise I'll
create a git-repository within the GNU Savannah's hosting service - what
do you think?
You need to learn about (git) clone, add, rm, commit and tag.
No problem.
4. d/rules: please, update to new (reduced) format. Your package is
very simple and it will work. Ask me if you have doubts. An example:
http://sources.debian.net/src/pcapfix/1.0.2-3/debian/rules/
Done.
You used a 'clean' target in your d/rules. The correct is use
'override_dh_auto_clean'. Please, 'man dh' and search by 'override'.
However, is easier use d/clean file (man dh_clean). But I think this
clean step in your package is unnecessary. Please, remove and test.
Thanks for you suggestion - I put now an empty 'override_dh_auto_clean'
target. Without it, debhelper executes 'make clean' and then creates the
man-pages again which is not required when building the debian packages -
the pages are provided with the tarball.
5. d/watch: add escapes before tarball dot (\.tar\.gz). Your watch is
showing the version 1.3.1. I already read about it in previous
messages. I need the final program in your site to check the
integrity.
Well, since '.tar.gz' is at the end of the string, and since I'm not going
to create on my web-page some other package-related files with funny
filenames ending with "<some char>tar<some_char>gz", I think that ".tar.gz"
without escapes is ok - it is not 100% exact but it is more readable and
'uscan --verbose' works perfectly. But if you mind, I can change it as
requested.
Nop. It is a grep (dot == any character except newline). Your d/watch
I'm aware of the meaning of the dot-character in d/watch file. My point
was that in this case the regex is precise enough and readability makes
more sense. But anyway, I changed it.
can work but the correct is escape the dots. Please, read it[1] if you
need know more about the watch file.
[1] http://eriberto.pro.br/blog/?p=1459
Ok, the dots are escaped now. Thanks for the link to your comprehensive
blog-article - it's an interesting read.
You can download the package source by:
wget http://gnu.mirendom.net/download.cgi/gnu/stda/stda-1.3.1.tar.gz
I think it was a mistake. Sorry.
I saw that your package depends of help2man to build. Please, add it
in d/control (Build-Depends).
Well, help2man is used to build as default the man-pages. But since I
provide the man-pages in the tarball, it's not necessary to build them.
Hence (as mentioned above) I override the dh_auto_clean target and I think
that Build-Depends is not needed.
Currently a new package is uploaded:
dget -x http://mentors.debian.net/debian/pool/main/s/stda/stda_1.3.1-2.dsc
Thanks Dimitar.
Cheers,
Eriberto
Thanks a lot,
Dimitar
Reply to: