[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#758056: RFS: binwalk/2.0.1-1



Hi again Andrey,




> Il Lunedì 25 Agosto 2014 6:47, Andrey Rahmatullin <wrar@debian.org> ha scritto:
> > On Mon, Aug 25, 2014 at 12:26:47AM +0100, Gianfranco Costamagna wrote:
>>  > At least some of the d can be made r, such as mtd-utils.
>>  I don't fully agree (I don't honestly know the tradeoff between a 
> bad user experience and the amount of the packages that one might be forced to 
> install), but fine, I changed that
> I think the main thing to consider is percentage of users that will need
> things that require these packages. Note that Recommends are installed by
> default anyway (in the default configuration), and now I think that some
> packages are maybe even better moved to Suggests (but I'm not 100% sure).
> There is also an interesting practice (cf. devscripts) to document what
> optional features require optionadditional recommends/suggests.
> 
>>  > There are several issues with the manpage, 3 of them are reported by
>>  > lintian and fourth one is the "SEE ALSO" section which is 
> not true.
>>  they are created with
>>  help2man binwalk --version-string=v2.0.1 > binwalk.1
> For omitting info section there is a -N argument.  Typos are better
> corrected in the source, and manpage-has-useless-whatis-entry suggests
> passing -n with a proper whatis text to help2man.
> 

fixed, thanks!

>>  should I file a bug there?
>>  Sorry but I don't feel good in fixing automatically created files... do 
> you have any advice for this?
> 
> 
>>  @@ -17,7 +17,6 @@ Architecture: any
>>   Depends: ${python:Depends}, ${shlibs:Depends}, 
> ${misc:Depends},
>>    python-matplotlib,
>>    python-pyqtgraph,
>>  - mtd-utils,
>>    ncompress,
>>    bzip2,
>>    arj,
> At least arj looks optional too, maybe others too.
> 

I moved all the decompression tools to Recommends leaving to Depends only the programs you really need to have in order to run the program, as Vincent said tar and gzip are already there, and they should fullfill most of the user cases.


thanks again, looking forward to fix the hardened build and I'll reupload!

cheers,

G.

> 
> -- 
> WBR, wRAR
>


Reply to: