Bug#745721: [Pkg-ime-devel] Bug#745721: RFS: libzhuyin/0.9.93-1
Hi ChangZhuo,
The new upstream version has new dates. So, you must update the
d/copyright file. Your sintax is wrong, because you put the upstreams
names before the years. Another point is that the packaging copyright,
usually, is an maintainer name. I suggest this sintax:
Files: *
Copyright: 2002-2006 James Su <suzhe@tsinghua.edu.cn>
2006-2013 Peng Wu <alexepico@gmail.com>
License: GPL-2+
Files: debian/*
Copyright: 2014 ChangZhuo Chen (陳昌倬) <czchen@gmail.com>
License: GPL-2+
Cheers,
Eriberto
2014-08-22 22:14 GMT-03:00 ChangZhuo Chen (陳昌倬) <czchen@gmail.com>:
> Hi,
>
> Since upstream has new version 0.9.99.20140718, I will pack this new
> version, with the following fix.
>
>> 1. d/control:
>> - What is '...' in long descriptions?
>
> It means "etc", "and so on". I will change to use "etc" if "..." causes
> confused.
>
>> - I didn't understand what is the '-data' package. What is this?
>> Can you improve the long description?
>
> Okay I will do that.
>
>> 2. d/copyright:
>> - I didn't find Peng Huang and BYVoid in upstream code. Can you
>> point me where you found them?
>> - The upstream code haven't a cmake directory. What is this?
>
> These are for 0.9.93, not 0.9.99.20140425. I forgot to remove them when
> upgrading to new version, sorry.
>
>> - The upstream code is GPL-2+, not GPL-2.
>>
>> 3. d/docs: points to NEWS (empty) and README (useless to final user).
>> Please, remove it.
>>
>> 4. d/rules: remove these comments:
>>
>> # -*- makefile -*-
>>
>> # Uncomment this to turn on verbose mode.
>
> Thanks for the review, I will update them.
>
> --
> ChangZhuo Chen (陳昌倬) <czchen@gmail.com>
> http://czchen.info/
> Key fingerprint = EC9F 905D 866D BE46 A896 C827 BE0C 9242 03F4 552D
Reply to: