Bug#742077: RFS: vcmi/0.95-1 [ITP]
Hi Eriberto,
Quoting Eriberto Mota (2014-08-19 14:29:34)
> Hi Johannes. Thanks for your reply.
sorry for my late reply but I was at the Debian Bootstrap sprint in Paris over
the weekend and am moving to Sweden tomorrow, so I'm a bit tight on free time
right now :)
> I understand your POV. However, from Debian Policy[1]:
>
> "Each program, utility, and function should have an associated manual
> page included in the same package. It is suggested that all
> configuration files also have a manual page included as well. Manual
> pages for protocols and other auxiliary things are optional.
>
> If no manual page is available, this is considered as a bug and should
> be reported to the Debian Bug Tracking System (the maintainer of the
> package is allowed to write this bug report themselves, if they so
> desire). Do not close the bug report until a proper man page is
> available."
>
> I have some very long manpages and short manpages too. When an user
> see a command but he don't know what is this, he always tries '$man
> command' to get an explanation.
>
> [1] https://www.debian.org/doc/debian-policy/ch-docs.html
Thank you for elaborating on this and sorry for my dismissive last message. At
the time of writing I had just finished writing man pages for 43 applications
and at that point I couldn't see man pages anymore XD
I added a man page to vcmiserver by patching the program to do the commandline
parsing before other initialization which would fail if vcmi is not yet
installed. Then I use help2man to generate the man page like for the other
applications.
For vcmilauncher I wrote a custom man page in `debian/vcmilauncher.1`.
> > There is 'hardening-no-fortify-functions' which is a false positive.
>
> Ok, the same case of the GPG signature.
I actually think they are different cases.
Checking for the GPG signature would be a pedantic warning that I would like to
receive every time I package a new upstream version because it reminds me to
check whether upstream still does not provide GPG signatures. If I override the
warning, then I will forget doing this.
Checking with blhc showed that the flags -fstack-protector and
--param=ssp-buffer-size=4 are not passed. But instead -fstack-protector-strong
is used. So things showd be fine, no?
> > And there is 'spelling-error-in-binary' which is a false positive as well.
>
> It is a classical Lintian override case.
Right.
> In your package, please:
>
> 1. I suggest you add a d/README.source explaining why it is DFSG and telling
> which files have been removed. I saw it in d/copyright but I suggest a
> detailed README too.
I added a d/README.source. Does it contain everything you think it needs to
contain?
> 2. d/copyright: I suggest put the range of years to 'Files: *'. Can be a
> unique range for all authors (2007-2014).
I figured out that the range 2002-2014 seems to be correct.
> I think that there are files with copyright not listed at d/copyright. I
> found lib/minizip/mztools.h. You can use 'grep -sri copyright *' to see all
> files.
I added "Xavier Roche" as the author of lib/minizip/mztools.h and added further
sections for cmake_modules/cotire.cmake and cmake_modules/FindFFmpeg.cmake. I
hope I caught them all now.
> 3. d/docs: the README.linux is useless because a Debian final user doesn't
> compile codes. Please, remove it.
That's right. I removed it.
> 4. A doubt: why you didn't make a separated package for shared libraries?
Upstream does not care about others using the shared library and will break ABI
and API with every release. The shared library is not intended to have any
users besides vcmi itself. There is a warning about this:
dpkg-shlibdeps: warning: can't extract name and version from library name 'libvcmi.so'
hat's why I put it in the vcmi subdirectory in /usr/share/<triplet>. Should the
library be put somewhere different in this case?
> 5. You need lintian overrides to 'I: vcmi: spelling-error-in-binary
> usr/games/vcmilauncher tEH the' and to 'I: vcmi: spelling-error-in-binary
> usr/lib/x86_64-linux-gnu/vcmi/libvcmi.so tEH the'.
I added those lintian overrides.
> 6. Please, add a simple manpage to usr/games/vcmilauncher and
> usr/games/vcmiserver.
Done.
> Thanks a lot for your work.
Thanks a lot for your feedback. It is very much appreciated!
I also refreshed the date in debian/changelog and uploaded the result to
mentors.
cheers, josch
Reply to: