Hola Eriberto,
first thank you for reviewing gcstar.
Am Mittwoch, den 20.08.2014, 13:42 -0300 schrieb Eriberto Mota:
> tags 753943 moreinfo
> thanks
>
> Hi again Jörg. :-)
>
> Please,
>
> 1. d/control: change from 'internet' to 'Internet' in long description.
ok.
> 2. d/copyright:
> - 2006-2011 to Alexander Wirt.
> - I found several names and years. Please, use 'grep -sri
> copyright * | grep -v debian' and review d/copyright carefully.
>
done
> 3. d/gcstar.lintian-overrides: make the script executable via d/rules
> or add a comment line explaining the motive of the override. I prefer
> the first.
>
I have add a chmod in d/rules and delete the override file.
> 4. Remove the useless file README.source.
>
done.
> 5. d/rules: remove the second line.
>
ok
> 6. d/watch: remove the first line and aditional final break lines. To
> see all blank final lines use 'tail -n1 *' in debian/.
>
ok.
> 7. Solve this Lintian message: I: gcstar:
> desktop-entry-lacks-keywords-entry
> usr/share/applications/gcstar.desktop
>
done.
> 8. d/dirs: I think that it is useless.
>
ok.
> 9. I got these errors when testing in cowbuilder:
>
> Net::FreeDB OK
> Ogg::Vorbis::Header::PurePerl OK
> Time::Piece OK
>
> I/O error : Permission denied
> I/O error : Permission denied
> Failed to write XML file; For permission problems, try rerunning as root
> I/O error : Permission denied
> I/O error : Permission denied
> Failed to write XML file; For permission problems, try rerunning as root
> Installing in /tmp/buildd/gcstar-1.7.0/debian/gcstar/usr/
>
> End of the installation
> No error
>
I have found two issues for this:
- The upstream install script removes previous installation files and
- it runs update-desktop-database & update-mime-database.
Both disabled via patch and in d/rules.
> Thanks for your work. Have a nice day!
>
> Cheers,
>
> Eriberto
>
[...]
Package is uploaded to mentors[1]. I make the git push this evening.
CU
Jörg
[1] http://mentors.debian.net/debian/pool/main/g/gcstar/gcstar_1.7.0-1.dsc
--
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56
Jörg Frings-Fürst
D-54526 Niederkail
Threema: SYR8SJXB
IRC: j_f-f@freenode.net
j_f-f@oftc.net
Attachment:
signature.asc
Description: This is a digitally signed message part