Re: Bug#756654: ITP: rohc -- RObust Header Compression (ROHC) library

[Jakub Wilk <jwilk@debian.org>]

I don't intend to sponsor this package. Sorry! ;-P

* Simon Paillard <spaillard@debian.org>, 2014-08-19, 21:49:
> > rohc is my first library package, I'd welcome a review.
>
> I'd be glad if someone can have a look:
> dsc at https://people.debian.org/~spaillard/rohc/1.7.0/rohc_1.7.0-1.dsc

It would be probably a good idea to avoid building documentation on 
buildds; that is, build it only in *-indep targets.

In the build log I see:

sh: 1: gs: not found
error: Problem running ghostscript gs -q -g754x72 -r383x383x -sDEVICE=ppmraw -sOutputFile=_form0.pnm -dNOPAUSE -dBATCH -- _form0.ps. Check your installation!

Looks like a build dependency on ghostscript is missing.

There's also this:

dpkg-gencontrol: warning: Pre-Depends field of package librohc-dev: unknown substitution variable ${misc:Pre-Depends}
dpkg-gencontrol: warning: package librohc0: unused substitution variable ${misc:Pre-Depends}

Compressed examples are unnecessarily difficult to play with. I'd rather 
avoid compressing them, especially when they are not very big.

I wanted to check if hardening is enabled, but blhc says:

NONVERBOSE BUILD:   CC       librohc_proto_la-ip_numbers.lo
NONVERBOSE BUILD:   CCLD     librohc_proto.la
NONVERBOSE BUILD:   CC       librohc_common_la-rohc_common.lo
... and so on.

--
Jakub Wilk