Hi Davy, You're also upstream, aren't you? (Then I'd recommend reading https://wiki.debian.org/UpstreamGuide ) (I assume you are upstream for the review below...) Let's go: - You probably missed pushing the 1.4 tar.gz to sf.net, because I uscan doesn't find it. If you plan to package from (upstream) git repository, you need to have a get-orig-source target in debian/rules. d/copyright: - Please recheck liceneses, it contains errors. For example: lib/* is not LGPL but MIT/X11 (use licensecheck). Section License: LGPL is not LGPL-text. - this is not the only error -- I recommend to use licensecheck -r -m --copyright * - there are a few files without copyright information. d/share/* This looks weird... What's your intention here by pre-packaging all that stuff. As you are upstream, you maybe want to include those file in your tarball and install from there. For this, please use standard debhelper mechanisms for installing stuff, for example dh_installchangelogs, dh_installmime ... (see debhelper(7)) Upstream-Changelogs do not belong into the debian-directory, they should be also in the upstream tarball. For your nice icon -- is there "source" (e.g a bigger vector file)? If so, it would be best if it could be d/polyhone.1 -> this file is basically empty. Please rewrite. (And include in your upstream tarball (BTW, you still need to retitle your ITP bug... How to was already written already in that bug) The package does not build in an pdebuilder enviroment: Project ERROR: Package portaudio-2.0 not found dh_auto_configure: qmake -makefile -nocache QMAKE_CFLAGS_RELEASE=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 QMAKE_CFLAGS_DEBUG=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 QMAKE_CXXFLAGS_RELEASE=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 QMAKE_CXXFLAGS_DEBUG=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 QMAKE_LFLAGS_RELEASE=-Wl,-z,relro QMAKE_LFLAGS_DEBUG=-Wl,-z,relro QMAKE_STRIP=: PREFIX=/usr returned exit code 2 debian/rules:7: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 E: Failed autobuilding of package W: no hooks of type C found -- ignoring I: unmounting /var/cache/pbuilder/ccache filesystem I: unmounting /home/tobi/pbuilder_repo/deps filesystem I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build//7284 and its subdirectories Stopping here... -- tobi
Attachment:
signature.asc
Description: This is a digitally signed message part