[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#750865: RFS: lynkeos.app/1.2-7



On 07-08-14 10:56, Yavor Doganov wrote:
>> Clean fails for me in my normal environment.
> 
> Again, I'd kindly ask you for some more information.  "fakeroot
> debian/rules clean" is supposed to fail if the build-dependencies are
> not installed as GNUSTEP_MAKEFILES will be undefined in that case.

Please see below. It is very similar to the other trace I sent you. I
think I finally understand. You recently fixed an issue in gnustep-make
which is exactly fixing this issue. As I am on wheezy, the gnustep-make
is not up-to-date. I already started on working my way through some of
the packages to backport them for local purposes (like this one ;) ) but
haven't got around the full set. That actually was the reason why I
requested the ~ in the dependencies on gnustep-make. Anyways, I accept
this failure, although I don't like it and I think that the clean target
should just work. If build dependencies are not present, obviously the
package is not build (or I think you can at least assume it) and clean
up should have less to do.

I have three more items (and then I will upload), but this time I
provide patches:
- Please install upstream changelog (as also noted by Lintian)
- Please fix a spelling error (found by Lintian): Written
- Please install the man page into a valid section for Debian. Of
  course it can be merged into the other manpage patch if you rather
  want that.

Paul

paul@wollumbin ~/tmp/sponsorships/lynkeos.app $ TEST=lintian pdebuild
dpkg-checkbuilddeps: Unmet build dependencies: gnustep-make (>= 2.6.6-2)
libavcodec-dev (>= 6:10.1) libavformat-dev (>= 6:10.1) libswscale-dev
(>= 6:10.1) libfftw3-dev libtiff-dev libgnustep-gui-dev
W: Unmet build-dependency in source
dpkg-buildpackage: source package lynkeos.app
dpkg-buildpackage: source version 1.2-7
dpkg-buildpackage: source changed by Yavor Doganov <yavor@gnu.org>
 dpkg-source --before-build lynkeos.app
dpkg-source: info: applying hurd-ftbfs-fix.patch
dpkg-source: info: applying compilation-errors.patch
dpkg-source: info: applying libav-build-fix.patch
dpkg-source: info: applying plist-icon.patch
dpkg-source: info: applying manpage-fix.patch
dpkg-source: info: applying libav-0.7.patch
dpkg-source: info: applying libav-9.patch
dpkg-source: info: applying libav-10.patch
dpkg-source: info: applying format-security.patch
dpkg-source: info: applying gcc-warnings.patch
dpkg-source: info: applying fix_manpage_section.patch
dpkg-source: info: applying fix_spelling_error.patch
dpkg-checkbuilddeps: Unmet build dependencies: gnustep-make (>= 2.6.6-2)
libavcodec-dev (>= 6:10.1) libavformat-dev (>= 6:10.1) libswscale-dev
(>= 6:10.1) libfftw3-dev libtiff-dev libgnustep-gui-dev
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied;
aborting
dpkg-buildpackage: warning: (Use -d flag to override.)
dpkg-buildpackage: warning: this is currently a non-fatal warning with
-S, but will probably become fatal in the future
 fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
   debian/rules override_dh_clean
make[1]: Entering directory `/media/home/paul/tmp/sponsorships/lynkeos.app'
/usr/bin/make -C Sources distclean
make[2]: Entering directory
`/media/home/paul/tmp/sponsorships/lynkeos.app/Sources'
GNUmakefile:1: /common.make: No such file or directory
GNUmakefile:42: /application.make: No such file or directory
make[2]: *** No rule to make target `/application.make'.  Stop.
make[2]: Leaving directory
`/media/home/paul/tmp/sponsorships/lynkeos.app/Sources'
make[1]: *** [override_dh_clean] Error 2
make[1]: Leaving directory `/media/home/paul/tmp/sponsorships/lynkeos.app'
make: *** [clean] Error 2
dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit
status 2


Description: Debian policy 12.1 says that man pages should be installed
 in sections 1 to 9.
Author: Paul Gevers <elbrus@debian.org>

--- a/GNUstep/lynkeos.1
+++ b/GNUstep/lynkeos.1
@@ -1,6 +1,6 @@
 .\" -*-Nroff-*-
 .\""
-.TH Lynkeos 1x 2005-04-17 "Lynkeos"
+.TH Lynkeos 1 2005-04-17 "Lynkeos"
 .SH NAME
 Lynkeos \- application dedicated to the processing of astronomical (mainly planetary) images taken with a webcam through a telescope.
 .SH SYNOPSIS

Description: Fix lintian reported spelling error
Author: Paul Gevers <elbrus@debian.org>

--- a/Sources/ffmpeg_access.c
+++ b/Sources/ffmpeg_access.c
@@ -358,7 +358,7 @@
   TIFFSetField(image, TIFFTAG_RESOLUTIONUNIT, RESUNIT_INCH);
   
   // Write the information to the file
-  printf("Writting file ... %d \n",width*height);
+  printf("Writing file ... %d \n",width*height);
   TIFFWriteEncodedStrip(image, 0, buffer, width*height*6);
   printf("done ...\n");
 

From 56647974dc1ca1a78d7180a66cf357ef59152680 Mon Sep 17 00:00:00 2001
From: Paul Gevers <elbrus@debian.org>
Date: Fri, 8 Aug 2014 20:44:59 +0200
Subject: [PATCH] install upstream ChangeLog into the binary package

---
 debian/rules |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 30196d7..179d9b6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -40,3 +40,6 @@ override_dh_link:
 override_dh_fixperms:
 	dh_fixperms
 	chmod -x $(d_app)/usr/share/GNUstep/*.app/ImageListWindow.gorm/*
+
+override_dh_installchangelogs:
+	dh_installchangelogs GNUstep/ChangeLog
-- 
1.7.10.4


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: