Bug#746392: RFS: fast-cpp-csv-parser/3-1 ITP
2014-08-08 9:46 GMT-03:00 Jörg Frings-Fürst <debian@jff-webhosting.net>:
> Hola Eriberto,
Hi Jörg! How are you?
> sorry for my late answer. Yesterday I have a lot of trouble at work.
No problems. I can wait up to 126 days and 3 hours. Not more. :-)
> Thanks you for your review.
You're welcome.
>>
>> I found several problems in this little package. Please:
>>
> fccp was one of my first debian packages. And after I hear thats very
> difficult to find a sponsor for ITPs I don't spend more time in it.
> Therefore a you have found a lot of mistakes :-( .
The life is hard! :-D
>> 2. d/copyright: is a good idea use the same license from upstream to
>> debian/. It can avoid a possible conflict between licenses.
> I prefer GPL for my work. In this package I don't see an conflict
> between GPL and BSD. If there is a conflict in the future, I have no
> problem to change the license.
Ok!
>> 7. d/rules: remove the useless comments and keep commented the verbose line.
>>
> Done. I've also added the section get-orig-source.
Ok!
>> 8. d/source.lintian-overrides: remove it. Create a d/watch and put an
>> explanation about the situation. Or let the Lintian speak. I prefer a
>> d/watch.
> Override removed. And a useless d/watch only for the lintian? I think
> then it is better to have a lintian info about that.
I will explain about it. There are people and a team[1] that work
around packages with missing or not working d/watch.
The first step is verify the watch and fix it or create one. The
second step is test the watch. So, a d/watch with a explanation will
save time and efforts.
Please, see here the sepwatch work[2].
[1] https://alioth.debian.org/projects/sepwatch
[2] https://alioth.debian.org/scm/viewvc.php/trunk/watchfiles/?root=sepwatch
>> 2. While I was driving from work to my house, I thought ... Where you
>> found the upstream version as being -3? I only found commits from Git
>> in upstream repository. So, you must use 0.0, the date and Git commit
>> as version (or other similar format). An example:
>> 0.0~git20140314.938cf1. In your case: 0.0~git20140429.0a2590. To see
>> more examples: $ dpkg -l | grep -i git.
> I get the -3 from here:
> https://code.google.com/p/fast-cpp-csv-parser/downloads/detail?name=csv_v3.h&can=1&q=
>
> But this is marked as deprecated. I have change the version to
> 0.0+git20140808~0a259084edad-1
Note that this date is about commit, not about download. So, I need
you change to 0.0~git20140429.0a2590.
You can use the whole commit number. But it will be very long. So,
commonly, we put the three initial bytes. Git command uses it too.
Example: commit 0a259084edadd08ea7ccaba4c6b38dd34a7c37cb. I can send
this command to Git repository:
$ git tag -am "Tagging test1." myprogram/test1 0a2590
But, if you wish, you can use 0.0+git20140429~0a259084edad or
0.0~git20140429.0a259084edad. I need you change the date. (note that
you can have several commits in same date)
Please, change the date and I will upload.
Have a nice day!
Cheers,
Eriberto
Reply to: