[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756331: RFS: aafigure/0.5-4 [ITA]



Hi Breno,

On 07/08/14 17:49, Breno Leitao wrote:
> On 07/28/2014 06:52 PM, Daniel Lintott wrote:
>> Hi,
>>
>> I'm not a DD so cannot sponsor your package. I haven't tried to build
>> the package, but a couple of comments.
> Thank you, I addressed you concerns and I just uploaded a new package:
> 
> http://mentors.debian.net/package/aafigure

I've added the debian-python mailing list to the email, as per Scott's
comments [1]:

> If you'd like to continue to maintain it within the team, it is relatively 
> easy to get team sponsorship.  If so, please update the package in the DPMT 
> svn and then you can ask for sponsorship via the team ML or on IRC.

I would say, it would be a good idea to liaise with them... especially
as the package gives the VCS in the python-modules team.

With regards to the VCS, from a quick look it looks like there is going
to be some housekeeping needed... as the 0.5-4 version in Debian doesn't
match 0.5-4 in VCS (and is UNRELEASED).

I'm not familiar with the SVN packaging workflow, so I can't really
comment more on what would be needed here, but I expect someone from the
python-modules team will have the answer.

Onto the package...

1. It's probably a good idea to add yourself to the debian/copyright
under the debian/* section (and possibly add Super Nathan Weber as well,
since he prepared the last version in Debian)

2. debian/compat & debian/control - debhelper these should probably be
bumped to 9 (or 8 at least)

3. debian/control - personally I would wrap-and-sort -s this which will
split the Build-Depends, Depends, Recommends to one per line which makes
it easier to diff.

4. debian/rules - this could probably be tidied up to use short-format
dh, but I haven't tried this


Apart from them, the package builds fine and it is lintian clean.

Regards,

Daniel Lintott


[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756331#19

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: