[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754652: RFS: uriparser/0.8.0.1-1 [ITA]



Hola Eriberto,

thanks for your notes about hardening.


Am Mittwoch, den 06.08.2014, 11:44 -0300 schrieb Eriberto Mota:
[...]
> Hi Jörg,
> 
> 1. In d/changelog you have 'uniparser (0.8.0+dfsg-1) unstable'.
> However, this revision didn't upload to Debian. Please, change to
> 'uniparser (0.8.0+dfsg-1) UNRELEASED'.
> 
I've change it to UNRELEASED. Also some minor changes (remove the
hardening line, date & time ...) done.


> 2. Please, commit the current code in Git. I suggest change the
> Vcs-Browser to http://anonscm.debian.org/cgit/collab-maint/uriparser.git
> (new URL).
Uploaded the branches master, upstream and pristine-tar. At the moment
untagged, which I do after uploading to unstable. 

I hope thats ok.

> 
> 3. d/copyright:
> 
> win32/MinGW/Makefile:# Copyright (C) 2008, Michael Anthony Puls II
> <shadow2531@gmail.com>
> 
> Please, use 'grep -isr copyright *' to search all author names and put
> it in d/copyright.
> 
Done. 

> 4. d/liburiparser-dev.install: remove *.a and *.so lines. Make a
> softlink to 'usr/lib/liburiparser.so.1.0.16' installed by
> liburiparser1 package. Don't install .a files if needn't. You can use
> dh_link to create the sotlink (file liburiparser-dev.links).
> 
Also done.

> 5. The prune-tarball.sh is useless now, right? Please, remove it. The
> README.Debian-source is useless too. Do you have a good reason to keep
> it?
I have removed both files. The remove of the non free files are also
documented in d/changelog. So the README* is also useless.

> 
> 6. In debian/rules, when using DH9, the line 'export
> DEB_BUILD_HARDENING=1' is unecessary.
> 
Also removed.


> Thanks for your work. I will wait you.
> 

The package is uploaded to mentors[1]; the changes are also in Vcs-Git.
 
> Cheers,
> 
> Eriberto
> 

Many thanks

Jörg

[1]
http://mentors.debian.net/debian/pool/main/u/uriparser/uriparser_0.8.0.1-1.dsc


-- 
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8  EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56

Jörg Frings-Fürst
D-54526 Niederkail

Threema: SYR8SJXB

IRC: j_f-f@freenode.net
     j_f-f@oftc.net





Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: