[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#753535: RFS: glances/2.0.1-1 [ITA] -- CLI curses based monitoring tool



Control: tag -1 + moreinfo

Hi Rémi,

On Fri, Jul 4, 2014 at 1:08 PM, Rémi Verchère <rverchere@gmail.com> wrote:
> Hi,
>
> Le 03/07/2014 15:46, Geoff a écrit :
>> Since glances need python3-psutil (>= 2.0.0), you should precise it as well in
>> the override file:
>>
>>     psutil python3-psutil (>= 2.0.0)
>
> Ok, corrected.
>
>> Moreover, I'm not a dh_python3 expert but I believe you can remove then the
>> python3-psutil Depends entry in debian/control since it's redundant with
>> debian/py3dist-overrides information.
>
> I deleted the psutil in debian/control, hoping it is correct. I also
> removed the lintian-overrides as bug #742693 is closed.
>
> The new package has been uploaded.

Your package mostly looks good, however debian/copyright is incomplete
(which is a blocker for upload) and lacking copyright/license
information for:
- glances/outputs/static/js/modernizr.custom.js,
debian/missing-sources/modernizr.custom.js
- i18n/de/LC_MESSAGES/glances.po

Also:
- please close your ITA bug in debian/changelog (e.g. add a changelog
entry similar to "Adopt package. (Closes: #752175)")
- this isn't that urgent, but for a future upload you should consider
fixing the test suite so that it doesn't FTBFS

Regards,
Vincent


Reply to: