[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756100: RFS: plowshare4/1.0.4-1 [ITP] -- command-line application to download files for file-sharing websites.



tags 756100 moreinfo
thanks


Hi Carl,

In d/copyright you should list all names shown in source code. I found
these extra notices:

src/modules/euroshare_eu.sh:# Copyright (c) 2011 halfman <Pulpan3@gmail.com>
src/modules/dataport_cz.sh:# Copyright (c) 2011 halfman <Pulpan3@gmail.com>
src/modules/oboom.sh:     * Version 2.2 Copyright Paul Johnston 2000 - 2009.
src/modules/1fichier.sh:# Copyright (c) 2011 halfman <Pulpan3@gmail.com>
src/modules/billionuploads.sh:# Copyright (c) 2012-2013 sapk <at> sapk.fr

Please, in d/copyright, add the email contact for Plowshare team, in
"2010-2014 Plowshare team".

In d/rules, remove the useless line '# -*- makefile -*-' and keep
commented the line 'export DH_VERBOSE=1'.

Please, create a VCS to control your /debian versions. You can use
github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to
d/control.

Lintian shows issues in your manpages. Please, read about it[1] and
fix the problem.

I would like to suggest you improve the long description in d/control,
quoting all supported sites. The content of the
/usr/share/plowshare/modules/ can be used to list these sites. It will
increase the possibility of the package be found when a user does an
'apt-cache search'.

Thanks for your work.

Regards,

Eriberto

[1] http://eriberto.pro.br/blog/?p=1289


Reply to: