[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#750677: RFS: buildnotify/0.3.5-1 [ITP]



tags 750677 moreinfo
thanks


Hi Daniel,

Please:

1. d/buildinotify.desktop.example has
'Name[en_GB]=buildnotify.desktop.example' and 'Name=buildnotify'. Is
right it? (I think that must be 'Name=buildnotify.desktop.example')

2. In d/rules remove the line '# -*- makefile -*-'. It is a useless comment.

3. Your package doesn't builds twice. So, allow the content
modification of the BuildNotify.egg-info/SOURCES.txt. To make it,
create the file debian/source/options with this content[1]:

extend-diff-ignore = "^BuildNotify.egg-info/SOURCES.txt$"

4. I suggest you add to long description a bit more of information. I
needed to access the upstream site to understand the program. Where
applicable, words as Gnome, KDE, etc. will improve the results when
doing an 'apt-cache search'.

5. In d/copyright, the better information is: "Copyright: 2009-2014,
Anay Nayak <anayak007@gmail.com>". This information can be viewed in
upstream VCS[2].

Thanks for your work.

Regards,

Eriberto

[1] https://www.debian.org/doc/manuals/maint-guide/dother.en.html#sourceopt
[2] https://bitbucket.org/Anay/buildnotify/commits/all?page=1


Reply to: