Bug#752360: RFS: volumecontrol.app/0.5-4 [RC] [ITA] -- Audio mixer for GNUstep
2014-08-01 10:52 GMT-03:00 Yavor Doganov <yavor@gnu.org>:
> Eriberto Mota wrote:
>> 1. d/changelog: what is '...' in some lines? I think that you'd put
>> something there.
>
> Well, this is a GNU style of writing changelogs... to indicate that
> something has been moved or renamed. That way, if you use Emacs'
> incremental search for a function/macro/whatever, you can go
> back/forth and discover that it has been renamed to something else (or
> moved elsewhere). For example:
>
> * composite.c (CHAR_COMPOSABLE_P): Replace unsafe macro with ...
> (char_composable_p): ... static function. All users changed.
>
> * xftfont.c (xftfont_open): Move call to XRenderQueryExtension ...
> * xterm.c (x_term_init) [HAVE_XFT]: ... to here. Adjust comment.
>
> I can understand if you find it confusing.
Ok! No problems. I didn't know it. Thanks for teaching.
>> 2. You should update the Git. Do you have access?
>
> I don't understand the remark. Everything was pushed long time ago so
> the package at mentors corresponded to the Git repository.
Sorry. I made a mistake.
>
>> 3. d/copyright: in VolumeControlInfo.plist, we have "Copyright =
>> "Copyright 2004, 2005 G\u00fcrkan Seng\u00fcn";". Please, update the
>> d/copyright.
>
> Done; I've reuploaded the package (and pushed that commit to Git).
Good!
Cheers,
Eriberto
Reply to: