Bug#756042: RFS: sandboxgamemaker/2.8.2+dfsg-1 [ITA][RC]

[Eriberto Mota <eriberto@debian.org>]

2014-07-30 23:15 GMT-03:00 Anthony F McInerney <afm404@gmail.com>:
> Hi Eriberto,

Hi!

> Thank you for taking the time to look over the package.

You're welcome.

> 1 to 5 done. Do you want me to upload a 2.8.2+dfsg-2 with my changes for
> review?

No. You must remove the package in mentors and reupload as dfsg-1.

> EDIT: dpkg: warning: while removing sandboxgamemaker, directory
> '/usr/share/sandboxgamemaker' not empty so not removed
> After removing postrm i got this on apt-get purge. The data installed by
> postinst is still present on my system.

Ok. It's right. The package installs a empty directory. So, dpkg will
remove a empty directory only. It is valid for all packages. So,
remove postrm because their acts are wrong. If you want check, install
a package, add an extra file in a directory and try to purge this
package.

>> >(in GIT you should put a tag after the upload to Debian only)
>
> Noted, i'll remove the tag

:-P

>> >6. Check if the content of d/README.source is being fulfilled.
>
> As far as i know this is correct, if you can be more explicit about anything
> i should be checking, or how i should be checking that would be great.
> (links to relevant documentation are also always welcome)

It was a simple request. I didn't read the file. But you are adopting
the package and needs check/fix all issues.


>> >Note that the package is a "monster" (is big) and I can ask for other
>> > changes in future.
>
>  A monster it is. Anything you see that needs fixing will get fixed.

Thanks! :-D

>> I think you can try (now or in next revision) modernize the package. As an
>> example, you can use the new (reduced) d/rules format.
>
> I'd like to, i didn't want to start breaking everything before getting it
> back into debian though, do you think it's possible to get it uploaded in
> it's current state and then work to bring it up to date?

Yes, no problem. We can upload. But, don't worry. I already converted
some packages to new format and all worked fine. The new format is
automated and smart. But I will upload as-is if you want it. So, we
can test the new format.

Cheers,

Eriberto